From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65035: 29.1; Port flycheck-emacs-lisp-initialize-packages to flymake Date: Sat, 09 Nov 2024 11:19:15 +0200 Message-ID: <86y11sn4rw.fsf@gnu.org> References: <87o73b6vmk.fsf@pengjiz.com> <86o73bds9e.fsf@gnu.org> <87ed44s8o7.fsf@pengjiz.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16411"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, 65035@debbugs.gnu.org To: Pengji Zhang , sbaugh@janestreet.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 09 10:20:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t9hdY-00046C-3F for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Nov 2024 10:20:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9hdT-0003jU-Hs; Sat, 09 Nov 2024 04:20:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9hdS-0003j4-Gp for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 04:20:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t9hdS-0001z2-6s for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 04:20:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=r6ExyN7YMP3KrdDcdY2RbQpzxT3qUurt+wEmAYHqn9w=; b=qSJwbWcVtLvaxjVJ7tf3WZvuaoM/EutD/HfxzCs00GxOX3r6B3SgWmORDDjQtYTggVaQkzGBRP+HFjsVTt6QhmcOgdsxoKnhbxdAiW8Ztgznnu3ofcX1Y3MiKuZSabl2FA5bkI+sLnXoxphPcx7URDQEF369j+Gz/sOqrKIKiWoowkwSCXAb2mVsl0oGDZVIWASjRLElWYa2cGL9wU8iOJT1HnLbaqOG08n8+HqTjF1c7AloGU1JfAf7FHHIbT0qKPgXs/2kPP/XYBXKH/3IlojrGGZF2BnYm7pzzu3FeDp/jBAbSM+5i18FtD3tJCRNIMcOESDaRJ2LIpl2T/QKTQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t9hdS-0001dc-36 for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 04:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2024 09:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65035 X-GNU-PR-Package: emacs Original-Received: via spool by 65035-submit@debbugs.gnu.org id=B65035.17311439696241 (code B ref 65035); Sat, 09 Nov 2024 09:20:02 +0000 Original-Received: (at 65035) by debbugs.gnu.org; 9 Nov 2024 09:19:29 +0000 Original-Received: from localhost ([127.0.0.1]:53411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9hcu-0001cb-M0 for submit@debbugs.gnu.org; Sat, 09 Nov 2024 04:19:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9hcr-0001cM-HM for 65035@debbugs.gnu.org; Sat, 09 Nov 2024 04:19:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9hcm-0001vc-0B; Sat, 09 Nov 2024 04:19:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=r6ExyN7YMP3KrdDcdY2RbQpzxT3qUurt+wEmAYHqn9w=; b=TH5Fpl1IFglXYwVB5ihw Geb6qBRJJWWxJLS0uZGkop5yNaaRHlrDDr3PNhLa+jb8EzljrFlfPHKX86ZbdHMbzOZWhccg/FeqA cyf//qgODw5MD3C7/kgncfV40yAFnS75DnfpUexiKDz8tj39c3hf6L/N1yA5JmgrCgeJqrz8anGQI 3TNnCqR9Vbs/75nGzr8aZ1GZtO8qCUHb8LiDCdm/EGk5twidcNwKbCo+CrviJdj054v/2q7UI1FRn FX7TVI6+bJ13JgY/eIMC6m2APtmRMjrYqwxxGvrI6YW0RUTEsBzF3KY5f8lXIxrTgmCb7bzXnmFey 7Cnr5stgwaGQTA==; In-Reply-To: <87ed44s8o7.fsf@pengjiz.com> (message from Pengji Zhang on Fri, 25 Oct 2024 19:50:48 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295110 Archived-At: > From: Pengji Zhang > Cc: sbaugh@janestreet.com, João Távora > , Eli Zaretskii > > Date: Fri, 25 Oct 2024 19:50:48 +0800 > > João Távora writes: > > > Feel free to use my patch of course. Stefan noted some time ago > > that -f package-initialize is the wrong flag to ask Emacs -Q to use > > elpa though, so there's something better. > > Thanks! I prepared a new patch based on yours. Thanks. Spencer, any comments? > +(defcustom elisp-flymake-byte-compile-activate-packages > + #'elisp-flymake-byte-compile-user-file-p > + "Whether to activate packages for Flymake elisp byte-compilation. > +If the value is nil, do not activate installed packages. If the value > +is a function, it is called with one argument, the source buffer to be > +checked, and installed packages are activated if the function returns > +non-nil. Otherwise, packages are always activated. > + > +Note that for efficiency the return value of the predicate function is > +cached the first time it is called. Type \\[revert-buffer-quick] to > +invalidate the cached value." I think the doc string should explicitly mention elisp-flymake-byte-compile-user-file-p, since it is used as the default value of the option. > + :type '(choice > + (const :tag "Don't activate" nil) > + (const :tag "Always activate" t) > + (const :tag "Activate for user files" > + elisp-flymake-byte-compile-user-file-p) > + (function :tag "Predicate function")) > + :group 'lisp) Please add a :version tag here.