From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73877: 30; rust-ts-mode: highlight the possible type suffix of number literals Date: Sat, 23 Nov 2024 14:58:02 +0200 Message-ID: <86y11aksyt.fsf@gnu.org> References: <874j587459.fsf@poincare.umons.ac.be> <87o739ikze.fsf@poincare.umons.ac.be> <87iktbao2j.fsf@poincare.umons.ac.be> <878qtquf1l.fsf@poincare.umons.ac.be> <6Lmo0XWams3ZDY4jnbU-3T-4oJIwmc-2NDwLWRUj6KG305DWdW_uT3MXPN4otagtPXr7gf8QcdE3CjoIKkJUIrY9c-Ulj-QC1JNJm2yKKac=@rjt.dev> <87cyis8tgf.fsf@poincare.umons.ac.be> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8638"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73877-done@debbugs.gnu.org, Christophe.TROESTLER@umons.ac.be, stefankangas@gmail.com To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 23 13:59:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEpjW-00020C-5e for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Nov 2024 13:59:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEpjC-00089j-4v; Sat, 23 Nov 2024 07:59:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEpj5-000891-MX for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 07:59:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEpj5-000267-E3 for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 07:59:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=U/g9/udxo8Ys4TR0jmdzdf7mF4/TOmN5JK6z0L4EeRk=; b=XrWx6dy1kSrSqlXfThnOqHTFFVXlBVy5ZqLmTZ+5eekkHsl0PZtOsI8g8GGW95XVBj/lxQ4vf9iRsdoVXF2k2i1wZ9KLcBViXA4tfgOPQuE+5MkgjdVpxZtrOcTx5fJM6arot7dX7X7q+sCQSWMYZs/HZ31dZzSUg8wmqXCQN3cMugUln4nzIDB+joj0FRgfWEMxtXA0JPMp/iAMoEjp4sZ9ChqEs9VIum6/2BsNfT2ZJmhMZcDRqU3Y1p7hlqyuzxpwitJcXmkut+bqYwMaGJ4asVqELzdlOyH85CzK1lOaKZwvKxznxE4vjbeJhJLKTNNyu/f5rFY0zgLyav6qyA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEpj4-0005XV-Tr for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 07:59:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2024 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 73877@debbugs.gnu.org, eliz@gnu.org, Christophe.TROESTLER@umons.ac.be Original-Received: via spool by 73877-done@debbugs.gnu.org id=D73877.173236669621229 (code D ref 73877); Sat, 23 Nov 2024 12:59:02 +0000 Original-Received: (at 73877-done) by debbugs.gnu.org; 23 Nov 2024 12:58:16 +0000 Original-Received: from localhost ([127.0.0.1]:57070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEpiK-0005WK-9W for submit@debbugs.gnu.org; Sat, 23 Nov 2024 07:58:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEpiI-0005W2-FQ for 73877-done@debbugs.gnu.org; Sat, 23 Nov 2024 07:58:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEpiC-0001wQ-5S; Sat, 23 Nov 2024 07:58:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=U/g9/udxo8Ys4TR0jmdzdf7mF4/TOmN5JK6z0L4EeRk=; b=Tli/a89JtmOh++f5S80F 82HxXkkLELW9sgm4WuaqIndyqIL1Grh8mq5xXgpIsfE62juCvU2z9Zt+iAltTsd+tYFgoOk9hZtvx s956aV7lIfM0vn+4pO2xwIyZBrHSPN+la12JSZtuUv7IHDhIEarSccRL1do+PLsROmIZWGh+KmcQH NDK9e9kbGzuuL9rYuEjsh7aI4jqlNQ8yFDo+e3LsCKroPxMmcKKgJtu8qYsdXoFLwWJtfxWaKePZU TKO9jX9jfOYgPZYdJrseXtcZ8vP9FQRpIlRNWB1ZitFs2EKfACpRYPLnsBIyfMCjuGN3L8HsxPvnp PQG2/FeVjPYgSg==; In-Reply-To: (message from Randy Taylor on Fri, 22 Nov 2024 00:57:32 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295828 Archived-At: > Date: Fri, 22 Nov 2024 00:57:32 +0000 > From: Randy Taylor > Cc: "73877@debbugs.gnu.org" <73877@debbugs.gnu.org>, Stefan Kangas , Eli Zaretskii > > On Monday, November 18th, 2024 at 10:14, Christophe TROESTLER wrote: > > > > On 15 November 2024 at 01:11 +01, Randy Taylor dev@rjt.dev wrote: > > > > > […] the patch didn't apply cleanly for me […] > > > > > > Here is an updated version of the patch against today's master branch. > > For some reason it still doesn't apply for me - not sure why. Maybe it's just me. > I always do "git format-patch -1" to generate my patches. > > > > > > […] If you do the same as treesit-font-lock-level, […] > > > > > > For some reason it did not work in the past but it does now, so that's how I proceeded. > > > > > You will also need to: (require 'rust-ts-mode) > > > > > > Ok — some tests do that, others don't, so I did not originally change that. I've now added the “require”. > > > > > After you make that change, I think you should be able to get rid of > > > this: > > > +(put 'rust-ts-mode-fontify-number-suffix-as-type 'safe-local-variable > > > + 'booleanp) > > > > > > I first thought that one may want to set that change for specific file but, you are right, it is more of a user choice that should be set in your own config. files. > > > > > In the font-lock-number.rs file, it looks like there is an extraneous > > > newline at the top of the file. > > > > > > Fixed. > > > > > BTW the current patch still doesn't apply against the latest master > > > for me. > > > > > > I have rebased it on the current origin/master. > > > > Best, > > C. > > Thanks for working on this and putting up with me - the patch looks > good to me. Eli, please install if you have no further comments. Thanks, installed on master, and closing the bug.