unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Randy Taylor <dev@rjt.dev>
Cc: 73877-done@debbugs.gnu.org, Christophe.TROESTLER@umons.ac.be,
	stefankangas@gmail.com
Subject: bug#73877: 30; rust-ts-mode: highlight the possible type suffix of number literals
Date: Sat, 23 Nov 2024 14:58:02 +0200	[thread overview]
Message-ID: <86y11aksyt.fsf@gnu.org> (raw)
In-Reply-To: <KbYI4j4rfuwaF31pQz-xlaN5DrLObpHypR4iie9jkWTwP-z6ftS-1mS6TqmfOXNhNjqqk0_LLrv9darBRi99Eb011Q--O6aBL8De2tNTsoA=@rjt.dev> (message from Randy Taylor on Fri, 22 Nov 2024 00:57:32 +0000)

> Date: Fri, 22 Nov 2024 00:57:32 +0000
> From: Randy Taylor <dev@rjt.dev>
> Cc: "73877@debbugs.gnu.org" <73877@debbugs.gnu.org>, Stefan Kangas <stefankangas@gmail.com>, Eli Zaretskii <eliz@gnu.org>
> 
> On Monday, November 18th, 2024 at 10:14, Christophe TROESTLER <Christophe.TROESTLER@umons.ac.be> wrote:
> > 
> > On 15 November 2024 at 01:11 +01, Randy Taylor dev@rjt.dev wrote:
> > 
> > > […] the patch didn't apply cleanly for me […]
> > 
> > 
> > Here is an updated version of the patch against today's master branch.
> 
> For some reason it still doesn't apply for me - not sure why. Maybe it's just me.
> I always do "git format-patch -1" to generate my patches.
> 
> > 
> > > […] If you do the same as treesit-font-lock-level, […]
> > 
> > 
> > For some reason it did not work in the past but it does now, so that's how I proceeded.
> > 
> > > You will also need to: (require 'rust-ts-mode)
> > 
> > 
> > Ok — some tests do that, others don't, so I did not originally change that. I've now added the “require”.
> > 
> > > After you make that change, I think you should be able to get rid of
> > > this:
> > > +(put 'rust-ts-mode-fontify-number-suffix-as-type 'safe-local-variable
> > > + 'booleanp)
> > 
> > 
> > I first thought that one may want to set that change for specific file but, you are right, it is more of a user choice that should be set in your own config. files.
> > 
> > > In the font-lock-number.rs file, it looks like there is an extraneous
> > > newline at the top of the file.
> > 
> > 
> > Fixed.
> > 
> > > BTW the current patch still doesn't apply against the latest master
> > > for me.
> > 
> > 
> > I have rebased it on the current origin/master.
> > 
> > Best,
> > C.
> 
> Thanks for working on this and putting up with me - the patch looks
> good to me. Eli, please install if you have no further comments.

Thanks, installed on master, and closing the bug.





      parent reply	other threads:[~2024-11-23 12:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-19 10:56 bug#73877: 30; rust-ts-mode: highlight the possible type suffix of number literals Christophe TROESTLER
2024-10-20 12:00 ` Stefan Kangas
2024-10-22 23:05   ` Randy Taylor
2024-10-24 15:22     ` Christophe TROESTLER
2024-10-27 19:07       ` Randy Taylor
2024-10-28 21:56         ` Christophe TROESTLER
2024-11-02 11:01           ` Eli Zaretskii
2024-11-02 19:48           ` Randy Taylor
2024-11-11 12:32             ` Christophe TROESTLER
2024-11-15  0:11               ` Randy Taylor
2024-11-18 15:14                 ` Christophe TROESTLER
2024-11-22  0:57                   ` Randy Taylor
2024-11-22  7:23                     ` Christophe TROESTLER
2024-11-23 12:58                     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y11aksyt.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=73877-done@debbugs.gnu.org \
    --cc=Christophe.TROESTLER@umons.ac.be \
    --cc=dev@rjt.dev \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).