From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74725: 31.0.50; image-scaling-factor is ignored by create-image Date: Sat, 07 Dec 2024 18:45:37 +0200 Message-ID: <86y10rh26m.fsf@gnu.org> References: <2304cad6-884f-4528-a85e-ab9c06b80016@orange.fr> <868qsrim4a.fsf@gnu.org> <2793f551-8715-4679-8f52-b4673dd6802d@orange.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28845"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74725@debbugs.gnu.org, alan@idiocy.org To: David Ponce , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 17:46:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJxwl-0007GZ-BX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 17:46:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJxwV-0005Q7-Qy; Sat, 07 Dec 2024 11:46:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJxwR-0005Pc-Q3 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 11:46:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJxwQ-0000TE-NQ for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 11:46:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=K5d5VyYmvgJ1pzsfmAxM56NAF+C4BEJb6sa3r/aVb3M=; b=OI9QnbmbVgo9LnX0ujpB4VGgPnVLAPbzapxAM0rpVr+2z6JY/c5GiC/EpTpkhinEv6DDZE5L0VkfmvwTcP3EC/zExMTwQIumNJdqEVAvS7EOrXVO6Bpu9iTjTwUOGDQQMJTvEwTZVetF3/SI1xFBbB5w9pooj4sBrO/VLU165fV5Rx/vSfXn3PsJY1JedI/IvLPtakigRz+CuDetWaE56dqfai8KcsdRqwZM/WoLVnUEppM7/NWAPgdamFKeAv26UybRijATSI5T10WT04m0Y4LSHly+NKZc19cGV6yzTqogkTlGWhcwWiygmBL/JBVY47ia9r8sOTifpn5bb7nsPQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJxwQ-00073z-7r for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 11:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74725 X-GNU-PR-Package: emacs Original-Received: via spool by 74725-submit@debbugs.gnu.org id=B74725.173358996027142 (code B ref 74725); Sat, 07 Dec 2024 16:46:02 +0000 Original-Received: (at 74725) by debbugs.gnu.org; 7 Dec 2024 16:46:00 +0000 Original-Received: from localhost ([127.0.0.1]:48317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJxwO-00073h-4p for submit@debbugs.gnu.org; Sat, 07 Dec 2024 11:46:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJxwL-00073S-Mb for 74725@debbugs.gnu.org; Sat, 07 Dec 2024 11:45:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJxwA-0000SF-Dw; Sat, 07 Dec 2024 11:45:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=K5d5VyYmvgJ1pzsfmAxM56NAF+C4BEJb6sa3r/aVb3M=; b=Qm28MacyfIMw pImcsP9ruMF9rO8pE4dPSFPIyAfE51GqpQ2tlo+kCqSDyojawQd3DA+HPQIo77VL6g8KY25ZoVCRs uNm/Wuwt/ihsNUtyhnlpVD5y3nRFNUh1WkkFNMAFwjvyRPnkARDRYeIjjVm84oyaujDFI41dil9+M q4PGvFDa0En+lGvS6VFetq/TCI+sZabLQHrcEEIvxbu0oKfpYyByk/ZOMDYAlR4dP3U+zacuRLav4 CR6G736g0zF00QRO2aYy+z2WZw2dQpY94+UtBinu41QdF4JmYoa7qjNr2rlfS5SjcrF8caezZ27aX wXXO9CGXtyJw9pbIz3oMVQ==; In-Reply-To: <2793f551-8715-4679-8f52-b4673dd6802d@orange.fr> (message from David Ponce on Sat, 7 Dec 2024 17:27:13 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296582 Archived-At: > Date: Sat, 7 Dec 2024 17:27:13 +0100 > From: David Ponce > > On 2024-12-07 16:49, Alan Third wrote: > > On Sat, Dec 07, 2024 at 04:49:41PM +0200, Eli Zaretskii wrote: > >>> Date: Sat, 7 Dec 2024 13:13:58 +0100 > >>> From: David Ponce via "Bug reports for GNU Emacs, > >>> the Swiss army knife of text editors" > >>> > >>> While working with images, I found what seems an issue to me with > >>> `create-image' which unconditionally set the :scale image property to > >>> 'default' when not specified, ignoring the value of the option > >>> `image-scaling-factor'. > >>> > >>> Here is an illustration: > >>> > >>> (let ((image-scaling-factor 1.0)) > >>> (image-size > >>> (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg"))) > >>> t)) > >>> => (63 . 63) > >>> > >>> (let ((image-scaling-factor 2.0)) > >>> (image-size > >>> (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg"))) > >>> t)) > >>> => (63 . 63) > >>> > >>> (image-size > >>> (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg" :scale 1))) > >>> t) > >>> => (48 . 48) > >>> > >>> (image-size > >>> (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg" :scale 2))) > >>> t) > >>> => (96 . 96) > >>> > >>> You can replace `image-size' with `insert-image' and observe the same. > >>> > >>> Here is a simple patch which fix the issue for me: > >>> > >>> diff --git a/lisp/image.el b/lisp/image.el > >>> index ce97eeb3ca1..2c1e865c336 100644 > >>> --- a/lisp/image.el > >>> +++ b/lisp/image.el > >>> @@ -536,7 +536,9 @@ create-image > >>> file-or-data) > >>> (and (not (plist-get props :scale)) > >>> ;; Add default scaling. > >>> - (list :scale 'default)) > >>> + (list :scale (if (numberp image-scaling-factor) > >>> + image-scaling-factor > >>> + 'default))) > >>> props))) > >>> ;; Add default smoothing. > >>> (unless (plist-member props :transform-smoothing) > >> > >> AFAIU, this is supposed to be taken care of in image.c. > >> > >> Alan, any ideas why this doesn't seem to work? > > > > It's because the image spec doesn't change so the image is pulled from > > the cache each time. > > > > Flushing the image between calls to image-size fixes it: > > > > (image-flush (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg")))) > > > > I'm not sure what the solution is here. My feeling is that > > image-scaling-factor isn't intended as something you set for each > > image as you load it, it's a set-and-forget setting, so perhaps we > > just need to document that in order for it to take effect the image > > cache needs to be flushed. > > > > Alternatively we make the image cache aware of it. > > > > Perhaps we can flush the cache automatically when it changes? That > > might give unexpected results too. > > This is exactly what I also observe. > It seems due to this change: > > author Po Lu 2024-06-03 16:34:51 +0800 > committer Po Lu 2024-06-03 16:36:29 +0800 > commit 56376585134d627f96c71b7b063ec51548d3ad3f (patch) > > Which replaced > > - (list :scale > - (image-compute-scaling-factor > - image-scaling-factor))) > > By this > > + (list :scale 'default)) > > In create-image. > > With the side effect that the image spec don't change when the scaling > factor changes, so the same cached image in always used. Po Lu, what were the reasons for that particular part of the commit?