From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: guillaume.brunerie@gmail.com, 74415-done@debbugs.gnu.org
Subject: bug#74415: 29.4; mouse-start-end does not respect syntax-table text properties
Date: Sat, 04 Jan 2025 12:54:21 +0200 [thread overview]
Message-ID: <86y0zqetnm.fsf@gnu.org> (raw)
In-Reply-To: <jwvbjxfqzte.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Fri, 13 Dec 2024 12:05:55 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>, 74415@debbugs.gnu.org
> Date: Fri, 13 Dec 2024 12:05:55 -0500
>
> > No, it was not dead code before, but changing the outer condition
> > makes it impossible for both the outer condition and the inner
> > condition to be true at the same time.
> > The current code is the following (inside a cond)
> >
> > ((and (= mode 1)
> > (= start end)
> > (char-after start)
> > (= (char-syntax (char-after start)) ?\())
> > (if (/= (syntax-class (syntax-after start)) 4) ; raw syntax code for ?\(
> > ;; This happens in CC Mode when unbalanced parens in CPP
> > ;; constructs are given punctuation syntax with
> > ;; syntax-table text properties. (2016-02-21).
> > (signal 'scan-error (list "Containing expression ends prematurely"
> > start start))
> > (list start
> > (save-excursion
> > (goto-char start)
> > (forward-sexp 1)
> > (point)))))
>
> I have the strong impression that this reflects the fact that the
> if+signal was a workaround which we're now replacing with an actual fix.
Evidently. So I've now installed my changes on the master branch,
after removing the unneeded code which signals an error, and I'm
therefore closing this bug.
prev parent reply other threads:[~2025-01-04 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 10:12 bug#74415: 29.4; mouse-start-end does not respect syntax-table text properties Guillaume Brunerie
2024-11-24 9:59 ` Eli Zaretskii
2024-11-25 23:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-28 16:02 ` Eli Zaretskii
2024-11-28 20:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-05 6:13 ` Guillaume Brunerie
2024-12-07 12:33 ` Eli Zaretskii
2024-12-09 19:21 ` Guillaume Brunerie
2024-12-13 17:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-04 10:54 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y0zqetnm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74415-done@debbugs.gnu.org \
--cc=guillaume.brunerie@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).