From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75354: (29.4; eww buffer is not displayed correctly when used from bookmark-jump ) Date: Wed, 08 Jan 2025 16:03:34 +0200 Message-ID: <86y0zl2yix.fsf@gnu.org> References: <87zfk6eekc.fsf@posteo.net> <87h669vjm9.fsf@posteo.net> <8634ht4fkd.fsf@gnu.org> <87sept5s67.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24168"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75354@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 08 15:04:57 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVWg4-00066V-I1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jan 2025 15:04:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVWft-0000w5-A1; Wed, 08 Jan 2025 09:04:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVWfD-0000lw-62 for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 09:04:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVWfC-0001Yr-5p for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 09:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=2JIdSNRVgXkeXS0Cr1m4wWGyHT3loaL8IOBmqj5mcBI=; b=r1kZfgkwWHyP7HH6sr6xZYy7/t8tn+cuAzOTvLkyahqiErGal6sDzJ+SjsSUONEJUUFrWkoXb1j+WkPQWLKhtdYe/ABW68HvodJxdkOL/A3umiZ1V1B2qguFfmW/NTrl4mqDoeg3cQuNkUZe8ue8QjkFW64p2xmawOfF2GD6I0zVcOeEH/U0T7iRvHNwfOkKmahu+ibVO5jhKv+74lJAAngxjjKWZXWlQUkOGD/OE23hnhwrji19vZyJ3WGXHcz9O+4bIm/sqyiE4MLyGU3vJ/Wx0cFmD7gBoQj91Y+3+h4tCBmVShBtjSk73scWu3nOHQCrJv2lcgVb8tuP7vSCKg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVWfB-0004QV-RZ for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 09:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2025 14:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75354 X-GNU-PR-Package: emacs Original-Received: via spool by 75354-submit@debbugs.gnu.org id=B75354.173634502716993 (code B ref 75354); Wed, 08 Jan 2025 14:04:01 +0000 Original-Received: (at 75354) by debbugs.gnu.org; 8 Jan 2025 14:03:47 +0000 Original-Received: from localhost ([127.0.0.1]:46520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVWex-0004Q1-44 for submit@debbugs.gnu.org; Wed, 08 Jan 2025 09:03:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40696) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVWeu-0004Pm-V3 for 75354@debbugs.gnu.org; Wed, 08 Jan 2025 09:03:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVWep-0000ho-7i; Wed, 08 Jan 2025 09:03:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2JIdSNRVgXkeXS0Cr1m4wWGyHT3loaL8IOBmqj5mcBI=; b=OJcisYdAivzD lZPTRLa2QXRlLCjYTjSeXskrw93NOCdObiiam8+PKLovucDK2k3ICYduKGbobCvfziFm1p2AnF2kE WR4211w7GrGPEdEjuKUm31G6wcIO9rcZnAfg8psmHM+qemWnLMl3Smc64KIMdM/UhYPmeSgPQKQnr 1tlzUrx0LrqYEfc/vImg4WOPgaI5XcsSxypf9+hQBUTiL5EgubW79pwjBGEEbAd8twUVWHfrLUp4r OQ35UpI7we5oq/tM3RrcBe1pyszcH+/p5HlUB2LAFGtwemF3j+NrrPRYMkoI0vuNRiyjEXx6V7rm/ M23DfqmN2bVGsfrMoWxocg==; In-Reply-To: <87sept5s67.fsf@posteo.net> (message from Thierry Volpiatto on Wed, 08 Jan 2025 13:52:32 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298782 Archived-At: > From: Thierry Volpiatto > Cc: Thierry Volpiatto , 75354@debbugs.gnu.org > Date: Wed, 08 Jan 2025 13:52:32 +0000 > > > This is contrary to what you originally wrote (with which I agree): > > Yes, after deeper search I found that `bookmark--jump-via` is behaving > like this AFAIU: > - It calls the handler which creates a new buffer related to bookmark. > - It then displays the current-buffer (the one before jumping to bmk) in > a window according to DISPLAY-FUNCTION and make the bookmark buffer current. > > This approach is OK as long as the handler fn doesn't try do do one part > of the job (window handling) itself, which is not the case at least with > eww and w3m. It is as well counter intuitive, DISPLAY-FUNCTION should > be called on the buffer generated by bookmark and not the contrary, so > this change makes the code simpler and easier to understand. > > > By contrast, the change you propose now will affect all the uses of > > bookmarks, everywhere, > > Yes, this is intended, in addition of fixing eww, it fixes w3m and also > the quit function of eww (actually broken). > > > which is riskier, given how many different variants of bookmark usage > > are out there. > > Tested here on many different kinds of bookmarks and work as expected > unlike the current code. OK, thanks. Let's leave this for a few days to give people time to post comments if they have them.