From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.bugs Subject: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace Date: Tue, 27 Oct 2015 20:51:42 -0500 Message-ID: <86wpu77ob5.fsf__42491.8294455439$1445997210$gmane$org@stephe-leake.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445997210 6323 80.91.229.3 (28 Oct 2015 01:53:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Oct 2015 01:53:30 +0000 (UTC) Cc: Andreas Schwab , 21766@debbugs.gnu.org, Markus Triska , Emacs developers To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 28 02:53:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZrFvK-00062D-SA for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Oct 2015 02:53:11 +0100 Original-Received: from localhost ([::1]:35176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrFvK-0001pP-7o for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Oct 2015 21:53:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrFvG-0001ol-2B for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 21:53:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrFvC-0000RT-Re for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 21:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrFvC-0000RM-OO for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 21:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZrFvC-0001yb-Gn for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 21:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Oct 2015 01:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21766-submit@debbugs.gnu.org id=B21766.14459971287497 (code B ref 21766); Wed, 28 Oct 2015 01:53:02 +0000 Original-Received: (at 21766) by debbugs.gnu.org; 28 Oct 2015 01:52:08 +0000 Original-Received: from localhost ([127.0.0.1]:41003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZrFuK-0001wq-I6 for submit@debbugs.gnu.org; Tue, 27 Oct 2015 21:52:08 -0400 Original-Received: from gproxy1-pub.mail.unifiedlayer.com ([69.89.25.95]:36195) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1ZrFuH-0001wh-Gg for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 21:52:06 -0400 Original-Received: (qmail 2066 invoked by uid 0); 28 Oct 2015 01:51:59 -0000 Original-Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy1.mail.unifiedlayer.com with SMTP; 28 Oct 2015 01:51:59 -0000 Original-Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw3 with id aXrl1r00s2UdiVW01XroVm; Wed, 28 Oct 2015 01:51:58 -0600 X-Authority-Analysis: v=2.1 cv=Zs1+dbLG c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=5lJygRwiOn0A:10 a=pGLkceISAAAA:8 a=Ix5xV5TN6PjERupaXpEA:9 Original-Received: from [76.218.37.33] (port=58835 helo=TAKVER2) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1ZrFtz-0006KM-DV; Tue, 27 Oct 2015 19:51:47 -0600 In-Reply-To: (Juanma Barranquero's message of "Tue, 27 Oct 2015 17:03:20 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108091 Archived-At: Juanma Barranquero writes: > This will be my first ERT test, so, does the following (attached, because > Gmail) patch look acceptable? Looks good to me, except see below. > And, it is possible to commit a file with trailing whitespace? Yes, but it's also very easy to lose it, thus breaking the test. I suggest instead to save the file without extra whitespace, and add code to the test to insert the extra whitespace. That way you can also add comments about why this test exists, etc. -- -- Stephe