From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52286: 28.0.90; [PATCH] Be consistent in naming of separators in context menu Date: Sun, 05 Dec 2021 19:52:41 +0200 Organization: LINKOV.NET Message-ID: <86wnkj6yzi.fsf@mail.linkov.net> References: <7a7d6b5c-ff5e-3d55-bef4-8ce8e163abdb@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13582"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52286@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 05 19:14:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtw1s-0003RQ-T0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 19:14:28 +0100 Original-Received: from localhost ([::1]:49442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtw1r-0001ZZ-V9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 13:14:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtvxa-0003oC-Tf for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 13:10:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtvxZ-0006Km-Rh for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 13:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtvxZ-0000eA-NT for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 13:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 18:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52286 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52286-submit@debbugs.gnu.org id=B52286.16387277542361 (code B ref 52286); Sun, 05 Dec 2021 18:10:01 +0000 Original-Received: (at 52286) by debbugs.gnu.org; 5 Dec 2021 18:09:14 +0000 Original-Received: from localhost ([127.0.0.1]:59356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtvwn-0000bn-T9 for submit@debbugs.gnu.org; Sun, 05 Dec 2021 13:09:14 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:41065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtvwl-0000Yn-PM for 52286@debbugs.gnu.org; Sun, 05 Dec 2021 13:09:13 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 58FAA240002; Sun, 5 Dec 2021 18:09:03 +0000 (UTC) In-Reply-To: <7a7d6b5c-ff5e-3d55-bef4-8ce8e163abdb@gmail.com> (Jim Porter's message of "Sat, 4 Dec 2021 13:57:31 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221629 Archived-At: > This is spun off from bug#52237[1]. There's a minor issue with > `context-menu-mode' where some of the separators are named `FOO-separator' > and others are named `separator-FOO'. Since these separators are partially > useful for context menu functions to find the right place to insert their > items, this inconsistency could be pretty confusing for authors of those > functions (e.g. in third-party packages). While I agree that it would be nice to release Emacs 28 with consistent menu separator names, the following list explains the current inconsistency where part of separator names were based on one naming convention, and part on another: lisp/cmuscheme.el (define-key map [separator-eval] '("--")) lisp/help-mode.el (define-key-after map [separator-1] menu-bar-separator) lisp/info.el (define-key-after map [separator-1] menu-bar-separator) (define-key-after map [separator-2] menu-bar-separator) (define-key-after map [separator-3] menu-bar-separator) lisp/international/mule-cmds.el (bindings--define-key map [separator-3] menu-bar-separator) (bindings--define-key map [separator-2] menu-bar-separator) (bindings--define-key map [separator-1] menu-bar-separator) (bindings--define-key map [separator-coding-system] menu-bar-separator) (bindings--define-key map [separator-input-method] menu-bar-separator) (bindings--define-key map [separator-mule] menu-bar-separator) lisp/menu-bar.el (bindings--define-key menu [separator-exit] (bindings--define-key menu [separator-print] (bindings--define-key menu [separator-tab] (bindings--define-key menu [separator-frame] (bindings--define-key menu [separator-window] (bindings--define-key menu [separator-save] (bindings--define-key menu [separator-tag-isearch] (bindings--define-key menu [separator-tag-search] menu-bar-separator) (bindings--define-key menu [separator-repeat-search] (bindings--define-key menu [separator-replace-tags] (bindings--define-key menu [separator-tag-file] (bindings--define-key menu [separator-xref] (bindings--define-key menu [separator-bookmark] (bindings--define-key menu [separator-search] (bindings--define-key menu [separator-undo] menu-bar-separator)) (bindings--define-key menu [separator-1] (bindings--define-key menu [separator-2] (bindings--define-key menu [separator-3] (bindings--define-key menu [separator-keys] (bindings--define-key menu [separator-file] (bindings--define-key menu [separator-games] (bindings--define-key menu [separator-encryption-decryption] (bindings--define-key menu [separator-net] (bindings--define-key menu [separator-vc] (bindings--define-key menu [separator-compare] (bindings--define-key menu [separator-spell] (bindings--define-key menu [separator-prog] (bindings--define-key menu [separator-desc-mule] lisp/net/eudc.el (define-key map [separator-eudc-email] menu-bar-separator) (define-key map [separator-eudc-query] menu-bar-separator) lisp/progmodes/compile.el (define-key map [separator-2] nil) (define-key-after map [separator-compile] menu-bar-separator) lisp/tool-bar.el (define-key-after (default-value 'tool-bar-map) [separator-1] menu-bar-separator) (define-key-after (default-value 'tool-bar-map) [separator-2] menu-bar-separator) (define-key-after (default-value 'tool-bar-map) [separator-3] menu-bar-separator) lisp/vc/ediff-hook.el (define-key menu-bar-ediff-menu [separator-ediff-misc] menu-bar-separator) (define-key menu-bar-ediff-menu [separator-ediff-windows] menu-bar-separator) (define-key menu-bar-ediff-menu [separator-ediff-regions] menu-bar-separator) (define-key menu-bar-ediff-menu [separator-ediff-directories] menu-bar-separator) (define-key menu-bar-ediff-menu [separator-ediff-files] menu-bar-separator) (define-key menu-bar-ediff-merge-menu [separator-ediff-merge] menu-bar-separator) menu-bar-ediff-merge-menu [separator-ediff-merge-dirs] menu-bar-separator) lisp/vc/vc-dir.el (define-key-after map [separator-1] menu-bar-separator) (define-key-after map [separator-2] menu-bar-separator) (define-key-after map [separator-3] menu-bar-separator) And another naming convention: lisp/cedet/cedet.el (define-key map [semantic-options-separator] #'undefined) (define-key map [cedet-menu-separator] #'undefined) lisp/cedet/ede.el (define-key cedet-menu-map [cedet-menu-separator] '("--"))) (define-key cedet-menu-map [cedet-menu-separator] nil) lisp/cedet/semantic.el (define-key edit-menu [semantic-completion-separator] (define-key edit-menu [semantic-edit-separator] (define-key navigate-menu [semantic-narrow-to-defun-separator] (define-key navigate-menu [semantic-navigation-separator] (define-key cedet-menu-map [semantic-options-separator] (define-key cedet-menu-map [cedet-menu-separator] '("--"))) (define-key cedet-menu-map [cedet-menu-separator] nil) (define-key cedet-menu-map [semantic-options-separator] nil) lisp/international/iso-cvt.el (define-key menu [load-as-separator] '("--")) (define-key menu [translate-separator] '("--")) lisp/menu-bar.el (bindings--define-key menu [scrollbar-separator] (bindings--define-key menu [linecolumn-separator] (bindings--define-key menu [datetime-separator] (bindings--define-key menu [custom-separator] (bindings--define-key menu [custom-separator] (bindings--define-key menu [showhide-separator] (bindings--define-key menu [mule-separator] (bindings--define-key menu [debugger-separator] (bindings--define-key menu [cursor-separator] (bindings--define-key menu [edit-options-separator] (bindings--define-key menu [highlight-separator] lisp/net/newst-plainview.el (define-key map [newsticker-separator-1] (define-key map [newsticker-separator-2] (define-key map [newsticker-separator-3] (define-key map [newsticker-separator-4] lisp/so-long.el (define-key-after map [so-long-actions-separator] (define-key-after map [so-long-help-separator]