bug#53529: 29.0.50; Error with debbugs 0.30 from ELPA

bug#53529: 29.0.50; Error with debbugs 0.30 from ELPA

[Arash Esbati]

Hi all,

debbugs 0.30 landed via package-update and while byte-compiling the new
version, Emacs says:

  Compiling file z:/pathto/.emacs.d/elpa/debbugs-0.30/debbugs-autoloads.el at Tue Jan 25 17:36:45 2022
  Entering directory ‘z:/pathto/.emacs.d/elpa/debbugs-0.30/’
  debbugs-autoloads.el: Error: End of file during parsing

Killing and re-starting Emacs leaves this message in the shell:

  Error loading autoloads: (user-error Local variables entry is missing
  the suffix)

Emacs starts though.  The error goes away if I delete debbugs and
re-start.  This is Emacs from git (b373c8ad) on Win10 compiled with
Msys2.

Best, Arash

bug#53529: 29.0.50; Error with debbugs 0.30 from ELPA

[Michael Albinus]

Arash Esbati <arash@gnu.org> writes:

> Hi all,

Hi Arash,

> debbugs 0.30 landed via package-update and while byte-compiling the new
> version, Emacs says:
>
>   Compiling file z:/pathto/.emacs.d/elpa/debbugs-0.30/debbugs-autoloads.el at Tue Jan 25 17:36:45 2022
>   Entering directory ‘z:/pathto/.emacs.d/elpa/debbugs-0.30/’
>   debbugs-autoloads.el: Error: End of file during parsing

I have installed debbugs 0.30 unde GNU/Linux, using

GNU Emacs 29.0.50 (build 29, x86_64-pc-linux-gnu, GTK+ Version
 3.24.31, cairo version 1.17.4) of 2022-01-22

In buffer *Compile-Log* there is

--8<---------------cut here---------------start------------->8---
Compiling internal form(s) at Tue Jan 25 17:58:40 2022
Leaving directory ‘/home/albinus/.emacs.d/elpa/debbugs-0.30’
\f
Compiling file /home/albinus/.emacs.d/elpa/debbugs-0.30/debbugs-browse.el at Wed Jan 26 13:19:19 2022
Entering directory ‘/home/albinus/.emacs.d/elpa/debbugs-0.30/’
\f
Compiling file /home/albinus/.emacs.d/elpa/debbugs-0.30/debbugs-gnu.el at Wed Jan 26 13:19:19 2022
\f
Compiling file /home/albinus/.emacs.d/elpa/debbugs-0.30/debbugs-org.el at Wed Jan 26 13:19:19 2022
\f
Compiling file /home/albinus/.emacs.d/elpa/debbugs-0.30/debbugs.el at Wed Jan 26 13:19:20 2022
--8<---------------cut here---------------end--------------->8---

No error, and also no compilation of debbugs-autoloads.el.

> Killing and re-starting Emacs leaves this message in the shell:
>
>   Error loading autoloads: (user-error Local variables entry is missing
>   the suffix)

Whatever it means. debbugs-autoloads.el contains at the end:

--8<---------------cut here---------------start------------->8---
;; Local Variables:
;; version-control: never
;; no-byte-compile: t
;; no-update-autoloads: t
;; coding: utf-8-emacs-unix
;; End:
;;; debbugs-autoloads.el ends here
--8<---------------cut here---------------end--------------->8---

This looks ok to me. The user error is raised in
`hack-local-variables--find-variables'. There has been a change in that
function recently (2dad332a1439b59a62cd5ed0d8e3626d9e91e3e5), don't know
whether this is related. Adding Stefan to Cc.

> Best, Arash

Best regards, Michael.

bug#53529: 29.0.50; Error with debbugs 0.30 from ELPA

[Arash Esbati]

Hi Michael,

Michael Albinus <michael.albinus@gmx.de> writes:

> No error, and also no compilation of debbugs-autoloads.el.

Thanks for your response.  I randomly took a package (the winner was
company-quickhelp) I've installed from MELPA, deleted it, re-started
Emacs and installed it again.  Same issue.  So it is not related to
debbugs, it was just the first package arrived here :)

I admit byte-compiling autoloads was also new to me.

> Adding Stefan to Cc.

Thanks, it seems the issue is more related to package itself.

Best, Arash

bug#53529: 29.0.50; Error with debbugs 0.30 from ELPA

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Arash Esbati <arash@gnu.org> writes:

>> Adding Stefan to Cc.
>
> Thanks, it seems the issue is more related to package itself.

Following-up myself, I think I found the issue.  Emacs writes ^M to
<package>-autoloads.el.  If I remove them manually, Emacs starts without
any errors.

I'm attaching the one for debbugs for your reference.  I don't see this
behavior with my older packages installed.  They also have this in the
local variables:

  ;; coding: utf-8

Maybe the change to

  ;; coding: utf-8-unix

on Windows is the issue?

Best, Arash

[-- Attachment #2: debbugs-autoloads-^M.el --]
[-- Type: application/emacs-lisp, Size: 5596 bytes --]

bug#53529: 29.0.50; Error with debbugs 0.30 from ELPA

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Following-up myself, I think I found the issue.  Emacs writes ^M to
> <package>-autoloads.el.  If I remove them manually, Emacs starts without
> any errors.

Hmmm...  a mix of Unix and DOS EOLs that's a problem, indeed.

> Maybe the change to
>
>   ;; coding: utf-8-unix
>
> on Windows is the issue?

It does seem to be the trigger, but I wonder why we end up with some DOS
EOLs in those files.

The sample you sent shows that the ^M are present on those parts of the
file what are "constant" at the beginning and the end.


        Stefan


> Best, Arash
>
> ;;; debbugs-autoloads.el --- automatically extracted autoloads  -*- lexical-binding: t -*-
> ;;
> ;;; Code:
> 
> (add-to-list 'load-path (directory-file-name
>                          (or (file-name-directory #$) (car load-path))))
> 
> \f
> ;;;### (autoloads nil "debbugs" "debbugs.el" (0 0 0 0))
> ;;; Generated autoloads from debbugs.el
>
> (register-definition-prefixes "debbugs" '("debbugs-"))
>
> ;;;***
> \f
> ;;;### (autoloads nil "debbugs-browse" "debbugs-browse.el" (0 0 0
> ;;;;;;  0))
> ;;; Generated autoloads from debbugs-browse.el
>
> (defconst debbugs-browse-gnu-url-regexp (format "^%s\\(%s\\)?\\([[:digit:]]+\\)$" "https?://\\(debbugs\\|bugs\\)\\.gnu\\.org/" (regexp-quote "cgi/bugreport.cgi?bug=")) "\
> A regular expression matching bug report URLs on GNU's debbugs instance.")
>
> (autoload 'debbugs-browse-url "debbugs-browse" "\
>
>
> \(fn URL &optional NEW-WINDOW)" nil nil)
>
> (when (boundp 'browse-url-default-handlers) (add-to-list 'browse-url-default-handlers `(,debbugs-browse-gnu-url-regexp . debbugs-browse-url)))
>
> (autoload 'debbugs-browse-mode "debbugs-browse" "\
> Browse GNU Debbugs bug URLs with debbugs-gnu or debbugs-org.
> With a prefix argument ARG, enable Debbugs Browse mode if ARG is
> positive, and disable it otherwise.  If called from Lisp, enable
> the mode if ARG is omitted or nil.
> The customer option `debbugs-browse-function' controls, which of
> the two packages is used for showing bugs.
>
> \(fn &optional ARG)" t nil)
>
> (register-definition-prefixes "debbugs-browse" '("debbugs-browse-"))
>
> ;;;***
> \f
> ;;;### (autoloads nil "debbugs-gnu" "debbugs-gnu.el" (0 0 0 0))
> ;;; Generated autoloads from debbugs-gnu.el
>
> (autoload 'debbugs-gnu-search "debbugs-gnu" "\
> Search for Emacs bugs interactively.
> Search arguments are requested interactively.  The \"search
> phrase\" is used for full text search in the bugs database.
> Further key-value pairs are requested until an empty key is
> returned.  If a key cannot be queried by a SOAP request, it is
> marked as \"client-side filter\".
>
> When using interactively, use \\[repeat-complex-command] after
> this command for reusing the argument list.  Be careful in
> editing the arguments, because the allowed attributes for QUERY
> depend on PHRASE being a string, or nil.  See Info node
> `(debbugs-ug) Searching Bugs'.
>
> \(fn PHRASE &optional QUERY SEVERITIES PACKAGES ARCHIVEDP)" t nil)
>
> (autoload 'debbugs-gnu-patches "debbugs-gnu" "\
> List the bug reports that have been marked as containing a patch." t nil)
>
> (autoload 'debbugs-gnu-tagged "debbugs-gnu" "\
> List the bug reports that have been tagged locally." t nil)
>
> (autoload 'debbugs-gnu-package "debbugs-gnu" "\
> List the bug reports of default packages, divided by severity.
>
> \(fn &optional PACKAGES)" t nil)
>
> (autoload 'debbugs-gnu "debbugs-gnu" "\
> List all outstanding bugs.
>
> \(fn SEVERITIES &optional PACKAGES ARCHIVEDP SUPPRESS TAGS)" t nil)
>
> (autoload 'debbugs-gnu-usertags "debbugs-gnu" "\
> List all user tags for USERS, which is (\"emacs\") by default.
>
> \(fn &rest USERS)" t nil)
>
> (autoload 'debbugs-gnu-bugs "debbugs-gnu" "\
> List all BUGS, a list of bug numbers.
> In interactive calls, prompt for a comma separated list of bugs
> or bug ranges, with default to `debbugs-gnu-default-bug-number-list'.
>
> \(fn &rest BUGS)" t nil)
>
> (register-definition-prefixes "debbugs-gnu" '("debbugs-gnu-"))
>
> ;;;***
> \f
> ;;;### (autoloads nil "debbugs-org" "debbugs-org.el" (0 0 0 0))
> ;;; Generated autoloads from debbugs-org.el
>
> (autoload 'debbugs-org-search "debbugs-org" "\
> Search for bugs interactively.
> Search arguments are requested interactively.  The \"search
> phrase\" is used for full text search in the bugs database.
> Further key-value pairs are requested until an empty key is
> returned.  If a key cannot be queried by a SOAP request, it is
> marked as \"client-side filter\"." t nil)
>
> (autoload 'debbugs-org-patches "debbugs-org" "\
> List the bug reports that have been marked as containing a patch." t nil)
>
> (autoload 'debbugs-org-tagged "debbugs-org" "\
> List the bug reports that have been tagged locally." t nil)
>
> (autoload 'debbugs-org "debbugs-org" "\
> List all outstanding bugs." t nil)
>
> (autoload 'debbugs-org-mode "debbugs-org" "\
> Minor mode for providing a debbugs interface in org-mode buffers.
>
> This is a minor mode.  If called interactively, toggle the
> `Debbugs-Org mode' mode.  If the prefix argument is positive,
> enable the mode, and if it is zero or negative, disable the mode.
>
> If called from Lisp, toggle the mode if ARG is `toggle'.  Enable
> the mode if ARG is nil, omitted, or is a positive number.
> Disable the mode if ARG is a negative number.
>
> To check whether the minor mode is enabled in the current buffer,
> evaluate `debbugs-org-mode'.
>
> The mode's hook is called both when the mode is enabled and when
> it is disabled.
>
> \\{debbugs-org-mode-map}
>
> \(fn &optional ARG)" t nil)
>
> (autoload 'debbugs-org-emacs-release-blocking-reports "debbugs-org" "\
> Show the reports that are blocking an Emacs release." t nil)
>
> (autoload 'debbugs-org-bugs "debbugs-org" "\
> List all BUGS, a list of bug numbers.
> In interactive calls, prompt for a comma separated list of bugs
> or bug ranges, with default to `debbugs-gnu-default-bug-number-list'." t nil)
>
> (register-definition-prefixes "debbugs-org" '("debbugs-org-"))
>
> ;;;***
> \f
> ;;;### (autoloads nil nil ("debbugs-pkg.el") (0 0 0 0))
>
> ;;;***
> \f
> ;; Local Variables:
> ;; version-control: never
> ;; no-byte-compile: t
> ;; no-update-autoloads: t
> ;; coding: utf-8-emacs-unix
> ;; End:
> ;;; debbugs-autoloads.el ends here

bug#53529: 29.0.50; Error with debbugs 0.30 from ELPA

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> It does seem to be the trigger, but I wonder why we end up with some DOS
> EOLs in those files.
>
> The sample you sent shows that the ^M are present on those parts of the
> file what are "constant" at the beginning and the end.

Could you see if the patch below happens to help?


        Stefan


diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index aa3e48155c..2e01449613 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1005,7 +1005,8 @@ package-autoload-ensure-default-file
   "Make sure that the autoload file FILE exists and if not create it."
   (unless (file-exists-p file)
     (require 'autoload)
-    (write-region (autoload-rubric file "package" nil) nil file nil 'silent))
+    (let ((coding-system-for-write 'utf-8-emacs-unix))
+      (write-region (autoload-rubric file "package" nil) nil file nil 'silent)))
   file)
 
 (defvar autoload-timestamps)

bug#53529: 29.0.50; Error with debbugs 0.30 from ELPA

[Arash Esbati]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Could you see if the patch below happens to help?

Yes, it does.  I deleted debbugs via package interface, applied your
change to `package-autoload-ensure-default-file' in scratch and eval'ed
the function, then I re-installed debbugs -- flawless.  Thank you.

I'll close this report when the fix is installed.

Best, Arash

bug#53529: 29.0.50; Error with debbugs 0.30 from ELPA

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Arash Esbati [2022-01-29 13:03:31] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Could you see if the patch below happens to help?
> Yes, it does.  I deleted debbugs via package interface, applied your
> change to `package-autoload-ensure-default-file' in scratch and eval'ed
> the function, then I re-installed debbugs -- flawless.  Thank you.

Great, thanks, pushed,


        Stefan