From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Sean Devlin <spd@toadstyle.org>, 58784@debbugs.gnu.org
Subject: bug#58784: 28.2; project-buffers incorrect under let-bound default-directory
Date: Mon, 21 Nov 2022 20:24:31 +0200 [thread overview]
Message-ID: <86wn7ojqm8.fsf@mail.linkov.net> (raw)
In-Reply-To: <208cd0a0-8244-9cac-ff16-9ef23b56ca9b@yandex.ru> (Dmitry Gutov's message of "Wed, 2 Nov 2022 01:35:58 +0200")
> So I just pushed that fix to master.
Unfortunately, this change broke 'C-x p p g':
@@ -1667,9 +1667,10 @@ project-switch-project
- (let ((default-directory dir)
- (project-current-inhibit-prompt t))
- (call-interactively command))))
+ (with-temp-buffer
+ (let ((default-directory dir)
+ (project-current-inhibit-prompt t))
+ (call-interactively command)))))
Because 'C-x p p' switches to a temporary buffer, then
'g' calls 'project-find-regexp' and 'project--read-regexp'.
But (thing-at-point 'symbol t) can't get a symbol at point
in the empty temporary buffer.
next prev parent reply other threads:[~2022-11-21 18:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 0:13 bug#58784: 28.2; project-buffers incorrect under let-bound default-directory Sean Devlin
2022-10-29 0:49 ` Dmitry Gutov
2022-10-31 17:47 ` Sean Devlin
2022-11-01 23:35 ` Dmitry Gutov
2022-11-02 15:18 ` Sean Devlin
2022-11-04 1:18 ` Dmitry Gutov
2022-11-04 16:39 ` Sean Devlin
2022-11-21 18:24 ` Juri Linkov [this message]
2022-11-23 3:48 ` Dmitry Gutov
2022-11-24 2:37 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wn7ojqm8.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=58784@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=spd@toadstyle.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).