From: Juri Linkov <juri@linkov.net>
To: Yuan Fu <casouri@gmail.com>
Cc: Stefan Kangas <stefankangas@gmail.com>, 60511@debbugs.gnu.org
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Date: Wed, 04 Jan 2023 09:47:10 +0200 [thread overview]
Message-ID: <86wn623fnl.fsf@mail.linkov.net> (raw)
In-Reply-To: <D066D2C0-342C-43C2-B290-6D68B89D3D93@gmail.com> (Yuan Fu's message of "Wed, 4 Jan 2023 00:02:36 -0700")
>>> This currently emits a warning if the ruby grammar is not installed:
>>>
>>> (treesit-ready-p 'ruby)
>>>
>>> I think it should *not* emit a warning, as no other predicates in Emacs
>>> do (e.g. `featurep', `integerp', etc.).
>>>
>>> It could have an optional flag to emit a warning, if there's a strong
>>> need for that. But personally, I'd rather see a new function for that.
>>>
>>> I also don't see much need for the `message' symbol as the second
>>> argument, so I'd simplify the API by dropping that part. It's currently
>>> unused in our tree.
>>
>> Like the argument NOERROR of `require', the argument QUIET of `treesit-ready-p'
>> could do the same.
>
> Maybe rename it to treesit-check-readiness?
I think treesit-ready-p already is a good name.
We just need to support more values in its argument QUIET,
with a new value that does nothing in case of an error,
and just returns nil.
next prev parent reply other threads:[~2023-01-04 7:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 11:19 bug#60511: 29.0.50; treesit-ready-p should not emit warning by default Stefan Kangas
2023-01-03 17:44 ` Juri Linkov
2023-01-04 7:02 ` Yuan Fu
2023-01-04 7:47 ` Juri Linkov [this message]
2023-01-08 1:31 ` Yuan Fu
2023-01-08 5:53 ` Eli Zaretskii
2023-01-08 8:39 ` Juri Linkov
2023-01-08 11:03 ` Eli Zaretskii
2023-01-08 17:35 ` Juri Linkov
2023-01-08 17:57 ` Eli Zaretskii
2023-01-08 18:11 ` Juri Linkov
2023-01-08 18:48 ` Eli Zaretskii
2023-01-08 18:14 ` Stefan Kangas
2023-01-08 18:28 ` Juri Linkov
2023-01-08 18:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wn623fnl.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=60511@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).