From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60977: 29.0.60; Dired: invalid face reference with dir symlinks Date: Sun, 22 Jan 2023 19:05:44 +0200 Organization: LINKOV.NET Message-ID: <86wn5e7imn.fsf@mail.linkov.net> References: <87mt6cdaao.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39856"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 60977@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 22 18:14:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJdvQ-000ABS-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Jan 2023 18:14:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJduw-0007Ks-0K; Sun, 22 Jan 2023 12:14:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJdus-0007JT-Pz for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 12:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJdus-0006XO-IP for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 12:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJdus-0005Zy-E8 for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 12:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jan 2023 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60977-submit@debbugs.gnu.org id=B60977.167440763321384 (code B ref 60977); Sun, 22 Jan 2023 17:14:02 +0000 Original-Received: (at 60977) by debbugs.gnu.org; 22 Jan 2023 17:13:53 +0000 Original-Received: from localhost ([127.0.0.1]:52565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJduj-0005Yp-0D for submit@debbugs.gnu.org; Sun, 22 Jan 2023 12:13:53 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:50527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJduh-0005YU-EX for 60977@debbugs.gnu.org; Sun, 22 Jan 2023 12:13:52 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 324A060002; Sun, 22 Jan 2023 17:13:44 +0000 (UTC) In-Reply-To: <87mt6cdaao.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 21 Jan 2023 00:02:39 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253950 Archived-At: > - Link target fontified with undefined 'dired-directory-face' face > - *Messages* says 'Invalid face reference: dired-directory-face' > > This seems to be a regression in Emacs 29 (https://bugs.gnu.org/57293): Thanks for finding this regression. > But I don't know whether it's acceptable for emacs-29, or whether it > conses too much during font lock. In the latter case, we could evaluate > dired-directory-face once (when dired-font-lock-keywords is defined), or > we could use the 'dired-directory' face directly. WDYT? I think the effect of consing is negligible.