From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching text outside filenames Date: Fri, 02 Jun 2023 09:28:39 +0300 Organization: LINKOV.NET Message-ID: <86wn0m4fq0.fsf@mail.linkov.net> References: <87li9hk5e5.fsf@web.de> <87wqt1vd0o.fsf@mail.jurta.org> <87d2ut4mji.fsf@web.de> <87620lvavl.fsf@mail.jurta.org> <87zjxxsd6c.fsf@web.de> <87vc8ke4os.fsf@mail.jurta.org> <86zgmutwx9.fsf@mail.linkov.net> <87o83ab67d.fsf@web.de> <86r185520f.fsf@mail.linkov.net> <87czjn39yf.fsf@web.de> <86y2215rbn.fsf@mail.linkov.net> <87sfbar6j6.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30262"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , 14013@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 02 09:06:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4yrg-0007bP-HU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Jun 2023 09:06:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4yrM-0005bF-9w; Fri, 02 Jun 2023 03:06:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4yrK-0005aT-DA for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 03:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q4yrK-0008F6-4J for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 03:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q4yrJ-00087H-Sp for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 03:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jun 2023 07:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14013 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14013-submit@debbugs.gnu.org id=B14013.168568952031084 (code B ref 14013); Fri, 02 Jun 2023 07:06:01 +0000 Original-Received: (at 14013) by debbugs.gnu.org; 2 Jun 2023 07:05:20 +0000 Original-Received: from localhost ([127.0.0.1]:39002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4yqe-00085I-By for submit@debbugs.gnu.org; Fri, 02 Jun 2023 03:05:20 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:50271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4yqb-00084y-Ui for 14013@debbugs.gnu.org; Fri, 02 Jun 2023 03:05:18 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 48A3440008; Fri, 2 Jun 2023 07:05:09 +0000 (UTC) In-Reply-To: <87sfbar6j6.fsf@web.de> (Michael Heerdegen's message of "Fri, 02 Jun 2023 03:34:37 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262738 Archived-At: >> - (remove-function (local 'isearch-filter-predicate) >> - #'wdired-isearch-filter-read-only) >> + (when wdired-search-replace-filenames >> + (remove-function (local 'isearch-search-fun-function) >> + #'dired-isearch-search-filenames) >> + (kill-local-variable 'replace-search-function) >> + (kill-local-variable 'replace-re-search-function)) > > Juri, when a user disables `wdired-search-replace-filenames' while still > in wdired-mode, won't we fail to undo these settings when the user > then returns to normal dired? - should we not better undo these things > unconditionally? If these calls are idempotent, we could remove the condition. Could you please confirm there is no adverse effect after removing this. Also there is another call at the end that can't be removed: (add-hook 'isearch-mode-hook #'dired-isearch-filenames-setup nil t) > Second question: could we advice (local 'replace-search-function) and > (local 'replace-re-search-function) instead of replacing the value (it > might be nicer to users of other packages)? This looks nicer in theory. But in practice I expect to see a lot of conflicts.