From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#67145: Modes in vc-deduce-backend Date: Mon, 13 Nov 2023 19:29:00 +0200 Organization: LINKOV.NET Message-ID: <86wmul606z.fsf@mail.linkov.net> References: <86zfzi6ucr.fsf@mail.linkov.net> <5424b015-4b19-4e86-8bab-0e7b495d3dab@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3682"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 67145@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 13 18:31:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2amm-0000l3-MX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Nov 2023 18:31:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2amX-00010c-BI; Mon, 13 Nov 2023 12:31:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2amP-0000na-Mp for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 12:31:23 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2amP-0000ow-5X for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 12:31:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2an4-00067N-OF for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 12:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Nov 2023 17:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67145 X-GNU-PR-Package: emacs Original-Received: via spool by 67145-submit@debbugs.gnu.org id=B67145.169989668723460 (code B ref 67145); Mon, 13 Nov 2023 17:32:02 +0000 Original-Received: (at 67145) by debbugs.gnu.org; 13 Nov 2023 17:31:27 +0000 Original-Received: from localhost ([127.0.0.1]:59289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2amU-00066J-I5 for submit@debbugs.gnu.org; Mon, 13 Nov 2023 12:31:26 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:56585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2amR-00065p-4Q for 67145@debbugs.gnu.org; Mon, 13 Nov 2023 12:31:23 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 6FC57FF806; Mon, 13 Nov 2023 17:30:34 +0000 (UTC) In-Reply-To: <5424b015-4b19-4e86-8bab-0e7b495d3dab@gutov.dev> (Dmitry Gutov's message of "Mon, 13 Nov 2023 16:11:34 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274277 Archived-At: >> Here is a patch that avoids hard-coding the modes in vc-deduce-backend. >> For example, it makes possible to replace shell-mode with comint-mode, etc. > > Look good, although it would be great to find a more meaningful name: > what kind of modes exactly should be in that list. Non-file-visiting? These modes are non-file-visiting as well: (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) ((derived-mode-p 'log-view-mode) log-view-vc-backend) ((derived-mode-p 'log-edit-mode) log-edit-vc-backend) ((derived-mode-p 'diff-mode) diff-vc-backend) What distinguishes these modes is that they are non-vc modes: '(dired-mode shell-mode eshell-mode compilation-mode) Then maybe (defvar vc-deduce-backend-nonvc-modes