From: Eli Zaretskii <eliz@gnu.org>
To: Eric Marsden <eric.marsden@risk-engineering.org>
Cc: 69749-done@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#69749: (bindat-type sint 32 t) -> unbound variable bitlen
Date: Sun, 17 Mar 2024 21:13:10 +0200 [thread overview]
Message-ID: <86wmq04qpl.fsf@gnu.org> (raw)
In-Reply-To: <000d8acf-bad4-432a-a775-0c03225674fe@risk-engineering.org> (message from Eric Marsden on Sun, 17 Mar 2024 19:28:17 +0100)
> Date: Sun, 17 Mar 2024 19:28:17 +0100
> Cc: 69749-done@debbugs.gnu.org
> From: Eric Marsden <eric.marsden@risk-engineering.org>
>
> Le 3/16/2024 à 12:16 PM, Eli Zaretskii a écrit :
> >> The patch I installed indeed doesn't impact the performance of the code.
> >> The underlying detail which requires `lexical-binding` to be active does
> >> cause the code for `sint` to be significantly less efficient than that
> >> for `uint`, tho, so if performance is important, you may prefer to use
> >> `uint` and do the conversion to a signed integer manually elsewhere. 🙁
> > Thanks, should we now close this bug?
>
> In my opinion yes, and thanks.
>
> (Not sure whether my cc to -done will work.)
It will.
prev parent reply other threads:[~2024-03-17 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 15:18 bug#69749: (bindat-type sint 32 t) -> unbound variable bitlen Eric Marsden
2024-03-13 11:53 ` Eli Zaretskii
2024-03-13 12:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <4a7ccaf7-02dc-4cca-b6e7-520ffb45dcac@risk-engineering.org>
2024-03-15 16:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-16 11:16 ` Eli Zaretskii
[not found] ` <000d8acf-bad4-432a-a775-0c03225674fe@risk-engineering.org>
2024-03-17 19:13 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wmq04qpl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69749-done@debbugs.gnu.org \
--cc=eric.marsden@risk-engineering.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).