From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70036: 30.0.50; Move file-truename to the C level Date: Sat, 30 Mar 2024 15:45:39 +0300 Message-ID: <86wmpjdh1o.fsf@gnu.org> References: <87le63xzjt.fsf@thornhill.no> <87ttkrqvru.fsf@betli.tmit.bme.hu> <87il17xsea.fsf@thornhill.no> <86wmpmhp0a.fsf@gnu.org> <874jcqygpn.fsf@thornhill.no> <875xx6muzt.fsf@ulti.tmit.bme.hu> <8734say2wi.fsf@thornhill.no> <87zfugoxwn.fsf@betli.tmit.bme.hu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12623"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70036@debbugs.gnu.org, theo@thornhill.no To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 30 13:46:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqY6D-000395-B0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Mar 2024 13:46:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqY5z-0005S9-2o; Sat, 30 Mar 2024 08:46:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqY5w-0005S1-RP for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 08:46:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqY5w-0001fq-JD for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 08:46:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqY5y-0005xk-5K for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 08:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Mar 2024 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.171180275822882 (code B ref 70036); Sat, 30 Mar 2024 12:46:02 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 30 Mar 2024 12:45:58 +0000 Original-Received: from localhost ([127.0.0.1]:44162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqY5t-0005ws-60 for submit@debbugs.gnu.org; Sat, 30 Mar 2024 08:45:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqY5o-0005wd-30 for 70036@debbugs.gnu.org; Sat, 30 Mar 2024 08:45:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqY5g-0001dS-1D; Sat, 30 Mar 2024 08:45:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NJn2g1/a824OEDRr9fnTur4Djx5HAZv8JncUeKJxsww=; b=qUfvwD1YFwC5 fvpL8Mp6Q/o7t5HTI7SjLaoZLNtBD1IteY1RTo71VDCvAc+0cd7+RGnDdjW0CeMlpoaseEvRWjRCh P3zoLZH+Z6K/M+HqihhFNp9jIX3dhBFBOdLD3eHi7xSQwfRxbooSIEG/HXKpkL/FADbW/lXnqQ13S h0WQxZSyc5zLzSF/3559yCLXnOj62kvIIJ1MRmlArIxZbqtR3FXQ+2W02Jr/5oMMSeom4sRhUd0Bf FJc0F0COzZzq7uM3eZlh9nzMGzNjOgZBvzK9RwGzWuY/NYIYku6t+ta6rjRouuWBR3jMY0sqnDtoi Fx1y22ms2URY/3oVsjoOUw==; In-Reply-To: <87zfugoxwn.fsf@betli.tmit.bme.hu> (message from Felician Nemeth on Sat, 30 Mar 2024 10:46:00 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282355 Archived-At: > From: Felician Nemeth > Cc: Eli Zaretskii , 70036@debbugs.gnu.org > Date: Sat, 30 Mar 2024 10:46:00 +0100 > > I think using find-buffer-visiting instead of get-file-buffer and > file-truename instead of expand-file-name in Eglot is problematic. > Let's say we have these files: > > /project/a.c > /project/a.h -> /other/a.h > > Eglot will communicate these file names to the LSP server: /project/a.c > and /other/a.h. Then the server cannot "associate" a.h with a.c. > Additionally, a.h will be outside of the LSP workspace. > > This indeed confuses clangd a bit: it only takes into account the > changes of buffer a.h when it is saved. (Because it assumes > /project/a.h is not opened in the editor.) Can LSP servers resolve symlinks? If they can, then expand-file-name is TRT, AFAIU.