From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70311: Crash when dnd-indicate-insertion-point is non-nil Date: Sat, 13 Apr 2024 12:20:48 +0300 Message-ID: <86wmp1pqj3.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2771"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70311@debbugs.gnu.org To: Greg Sexton , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 13 11:22:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvZaD-0000S2-Tp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Apr 2024 11:22:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvZa8-0004eA-58; Sat, 13 Apr 2024 05:21:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvZa6-0004cS-N3 for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 05:21:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvZa5-0005hr-Qd for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 05:21:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvZaF-0005HO-Vw for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 05:22:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2024 09:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70311 X-GNU-PR-Package: emacs Original-Received: via spool by 70311-submit@debbugs.gnu.org id=B70311.171300007119810 (code B ref 70311); Sat, 13 Apr 2024 09:22:03 +0000 Original-Received: (at 70311) by debbugs.gnu.org; 13 Apr 2024 09:21:11 +0000 Original-Received: from localhost ([127.0.0.1]:60135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZZO-00059E-1R for submit@debbugs.gnu.org; Sat, 13 Apr 2024 05:21:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZZL-00057h-V8 for 70311@debbugs.gnu.org; Sat, 13 Apr 2024 05:21:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvZZ6-0005TJ-8h; Sat, 13 Apr 2024 05:20:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7cdL48ifKpBQXy+er2covEed3AFFuGMDXzXDR9vlQCY=; b=oQVde4YmuoTe KDdz9zeFVuxM9IwTtqKNb4xuTnFnEqcPLhEsnul1fPdbANVAZbNRii6Mqv9IGkYd1M4qEYvNpldHE J6UroFspX/mcZg4bwQukw80iS8oRX8uc606cJLJFOFUQspQvyeYDlNi1w3elgxVXPWyNbdl1Q/2cD hy4ADB1fQfL268KB6TAajRQFWIhjZ5gseg0Fy3Dp9tlUc3k9CjGQ4LC579n49mYS1dFNVF9nSOCPM T+k2yFPf7YjDihavynX0dXpPuDxDyQBd3Rb3ciwr1uI/YHFUMWtQy92sXZ8rRQX5LcfJcDOF1NucZ tPzMxZPdTMF72WpA+oNwmg==; In-Reply-To: (message from Greg Sexton on Tue, 9 Apr 2024 11:26:41 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283194 Archived-At: > From: Greg Sexton > Date: Tue, 9 Apr 2024 11:26:41 +0100 > > Emacs (29.1.90) can crash on Mac OS X when dnd-indicate-insertion-point > is non-nil. > > I'm not able to deterministically reproduce this, but I have a high > success rate dragging a file over the window and just randomly moving > it around without releasing the click. > > This said, I attached a debugger and found the root cause. > > There is code that looks like this in dnd-handle-movement: > > (when dnd-indicate-insertion-point > (ignore-errors > (goto-char (posn-point posn)))) > > posn-point can return nil, which causes goto-char to call > wrong_type_argument, this reaches signal_or_quit (eval.c), which calls > emacs_abort as waiting_for_input is true. > > A quick fix might be to when-let the result of posn-point, but I'm > unsure if waiting_for_input being true points to a deeper issue. Po Lu, any comments or suggestions?