From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode Date: Thu, 18 Apr 2024 13:31:25 +0300 Message-ID: <86wmovdksi.fsf@gnu.org> References: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 70362-done@debbugs.gnu.org, noah.v.peart@gmail.com To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 18 12:33:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxP59-0006ex-Jx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Apr 2024 12:33:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxP4j-0005tY-Dc; Thu, 18 Apr 2024 06:33:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxP4g-0005rJ-7b for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 06:33:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxP4f-0000at-Rf for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 06:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxP4s-0000Zf-MP for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 06:33:14 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Apr 2024 10:33:12 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 70362@debbugs.gnu.org, eliz@gnu.org, noah.v.peart@gmail.com Original-Received: via spool by 70362-done@debbugs.gnu.org id=D70362.17134363341862 (code D ref 70362); Thu, 18 Apr 2024 10:33:12 +0000 Original-Received: (at 70362-done) by debbugs.gnu.org; 18 Apr 2024 10:32:14 +0000 Original-Received: from localhost ([127.0.0.1]:51591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxP3m-0000TQ-R5 for submit@debbugs.gnu.org; Thu, 18 Apr 2024 06:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxP3U-0000RD-TR for 70362-done@debbugs.gnu.org; Thu, 18 Apr 2024 06:32:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxP3A-0000Av-Vt; Thu, 18 Apr 2024 06:31:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PuF87eAGV3tnupi+WY6hqIcQIXHOT2DHh/BVrZN/7Qs=; b=dtehh7ITZLL8 zzrUX5AKZ0gNiGsRkzrNCmoZkk9jXtJ9b6aArQCgXafYKK4nz7ptA6IZldkGauPpHlPexydsSaBoP ldws7rneW3p8gCgzto+wXYD/Dtv8zR0aYDXrW+Ns0KGzMMHQFZOjN2YMCDMWOg+axYl1a6nlxqojN Ip3TNBUYkquwOSW0iX/vJ+uK9V4V+SXLbFilqV/vskW3hUmh9KsjGwOgVt9nvT6PUAqMGHN1KKyAN jU/yAs4Yj0S1kF/kkedVVNfzIv5RNyEXK7Ooy7TOG7TWp2e28flKUQ/WM7N9aV7FByehKPtyTw6FO P4RD6tGd0Lu8HTjZ1QLnOQ==; In-Reply-To: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@gmail.com> (message from Yuan Fu on Sun, 14 Apr 2024 16:32:43 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283544 Archived-At: > From: Yuan Fu > Date: Sun, 14 Apr 2024 16:32:43 -0700 > Cc: Noah Peart , > Eli Zaretskii , > 70362@debbugs.gnu.org > > > Dmitry Gutov writes: > > > On 13/04/2024 10:40, Noah Peart wrote: > >> I put it at level 3 following the conventions in other treesit modes > >> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put > >> builtins at level 3. > >> But, I haven't done a full census of the ts modes so there might be > >> variability. > > > > SGTM. If classic major modes highlight a thing (and they do that for > > built-ins), we usually put it in the default highlighting for ts modes > > as well (meaning level 3 or lower). > > Right. And the patch looks good to me. Thanks, installed on master, and closing the bug.