From: "Elijah G." <eg642616@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71313@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert
Date: Tue, 04 Jun 2024 18:54:19 -0600 [thread overview]
Message-ID: <86wmn4ky4k.fsf@gmail.com> (raw)
In-Reply-To: <8634pumezc.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Jun 2024 14:40:23 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Elijah G." <eg642616@gmail.com>
>> Cc: 71313@debbugs.gnu.org
>> Date: Sun, 02 Jun 2024 21:14:34 -0600
>>
>> >> From: "Elijah G." <eg642616@gmail.com>
>> >> Date: Sat, 01 Jun 2024 18:17:42 -0600
>> >>
>> >> this little patch allow insert any package keywords when using
>> >> auto-insert for insert elisp header lines.
>> >>
>> >> This is more a bugfix, since there is a bug when using Vertico that get
>> >> stuck in the keywords part, that bug can also apply to other completion
>> >> UIs or frameworks.
>> >>
>> >> Also there are some packages that uses non-standard keywords, i think it
>> >> would be better allowing insert other keywords.
>> >
>> > I'm not sure why it makes sense to allow keywords that are not in
>> > finder-known-keywords. Such a keyword will never be used by any
>> > finder commands.
>>
>> You are right, I think I've found a better way for this bugfix.
>> Please see the new patch attached below, thanks.
>
> Thanks, but how will an empty string "fix bugs from 3rd-party
> completion UI"? What am I missing here?
When using Completions UI such as Vertico or Helm, there is no way to
exit from Keyword Section to go to next auto-insert Sections unless the
user press a key sequense, for auto-insert input a empty string allow
close Keyword section without cancelling the next auto-insert actions.
This can be more a problem with `completing-read' than Completions UI,
that is why setting an empty string as default value fix this and can
fix this similar issue to other completions packages.
next prev parent reply other threads:[~2024-06-05 0:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 0:17 bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert Elijah G.
2024-06-02 5:44 ` Eli Zaretskii
2024-06-03 3:14 ` Elijah G.
2024-06-03 11:40 ` Eli Zaretskii
2024-06-05 0:54 ` Elijah G. [this message]
2024-06-05 5:24 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-05 11:32 ` Eli Zaretskii
2024-06-07 5:10 ` Elijah G
2024-06-07 5:48 ` Thierry Volpiatto
2024-06-08 4:32 ` Elijah G
2024-06-08 13:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wmn4ky4k.fsf@gmail.com \
--to=eg642616@gmail.com \
--cc=71313@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).