unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: richard@freakingpenguin.com, rudalics@gmx.at
Cc: 70819@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#70819: [PATCH] Make clone-indirect-buffer-other-window use other window
Date: Sat, 08 Jun 2024 14:45:57 +0300	[thread overview]
Message-ID: <86wmmzd5e2.fsf@gnu.org> (raw)
In-Reply-To: <861q5q1gbf.fsf@gnu.org> (message from Eli Zaretskii on Sat, 25 May 2024 10:49:56 +0300)

Ping! Ping! Richard, please augment your patch according to Martin's
comments, so we could install this.

> Cc: martin rudalics <rudalics@gmx.at>, 70819@debbugs.gnu.org,
>  monnier@iro.umontreal.ca
> Date: Sat, 25 May 2024 10:49:56 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> Ping!  Richard, could you please augment your pat6ch according to
> Martin's comments and resubmit?
> 
> > Date: Mon, 13 May 2024 10:05:52 +0200
> > Cc: Eli Zaretskii <eliz@gnu.org>, 70819@debbugs.gnu.org
> > From: martin rudalics <rudalics@gmx.at>
> > 
> >  > -(defun clone-indirect-buffer-other-window (newname display-flag &optional norecord)
> >  > +(defun clone-indirect-buffer-other-window (newname &optional norecord)
> >  >     "Like `clone-indirect-buffer' but display in another window."
> >  >     (interactive
> >  >      (progn
> >  > @@ -10658,8 +10658,8 @@ Returns the newly created indirect buffer."
> >  >        (list (if current-prefix-arg
> >  >   	       (read-buffer "Name of indirect buffer: " (current-buffer)))
> >  >   	   t)))
> >  > -  (let ((pop-up-windows t))
> >  > -    (clone-indirect-buffer newname display-flag norecord)))
> >  > +  (switch-to-buffer-other-window
> >  > +   (clone-indirect-buffer newname nil norecord)))
> > 
> > I see two problems:
> > 
> > (1) 'clone-indirect-buffer-other-window' would still have to obey the
> >      DISPLAY_FLAG argument.  Some application may rely on the fact that
> >      'clone-indirect-buffer-other-window' doesn't display the buffer if
> >      it is nil.
> > 
> > (2) 'switch-to-buffer-other-window' does not get passed the NORECORD
> >      argument.
> > 
> > martin
> > 
> 
> 
> 
> 





  reply	other threads:[~2024-06-08 11:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07 16:19 bug#70819: 29.3; clone-indirect-buffer-other-window is inconsistent with *-other-window commands Richard Sent
2024-05-11  9:29 ` Eli Zaretskii
2024-05-12  8:30   ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-13  2:26   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-13  3:14     ` bug#70819: [PATCH] Make clone-indirect-buffer-other-window use other window Richard Sent
2024-05-13  5:22       ` Eli Zaretskii
2024-05-13  8:05       ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25  7:49         ` Eli Zaretskii
2024-06-08 11:45           ` Eli Zaretskii [this message]
2024-06-08 13:29             ` Eli Zaretskii
2024-05-27 15:32 ` bug#70819: [PATCH v2] Make clone-indirect-buffer-other-window use other window (bug#70819) Richard Sent
2024-05-28  8:04   ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 12:18   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wmmzd5e2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70819@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=richard@freakingpenguin.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).