From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68765: 30.0.50; Adding window-tool-bar package. Date: Sun, 09 Jun 2024 15:23:18 +0300 Message-ID: <86wmmy9ufd.fsf@gnu.org> References: <86v82ok8bq.fsf@gnu.org> <76360aef38fd8e45a26b48c1d9df608c@finder.org> <86h6e7k2t9.fsf@gnu.org> <435f03489dab91624a0d60f57b0ed698@finder.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38488"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 68765-done@debbugs.gnu.org, monnier@iro.umontreal.ca, juri@linkov.net To: Jared Finder Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 09 15:11:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGIKL-0009o2-LV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jun 2024 15:11:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGIJu-0006Kv-9K; Sun, 09 Jun 2024 09:10:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGIJr-0006Kb-Jz for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 09:10:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGIJr-00033t-BP for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 09:10:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGIK7-0003qw-3l for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 09:11:03 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2024 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68765 X-GNU-PR-Package: emacs Mail-Followup-To: 68765@debbugs.gnu.org, eliz@gnu.org, jared@finder.org Original-Received: via spool by 68765-done@debbugs.gnu.org id=D68765.171793863014721 (code D ref 68765); Sun, 09 Jun 2024 13:11:02 +0000 Original-Received: (at 68765-done) by debbugs.gnu.org; 9 Jun 2024 13:10:30 +0000 Original-Received: from localhost ([127.0.0.1]:36633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGIJZ-0003pK-F9 for submit@debbugs.gnu.org; Sun, 09 Jun 2024 09:10:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGHzn-0002wo-5z for 68765-done@debbugs.gnu.org; Sun, 09 Jun 2024 08:50:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGHZz-00035f-9T; Sun, 09 Jun 2024 08:23:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=L/f5dcO85ahT6zDWQltNV5MwjIWO1Xk3PbeH5vq28E8=; b=Ye9zRkVlat7z ynTeprpEnSxgdfrpz71ZL+srkS7LmIYBneu5lS97axWv8/xdVlkw3QNa7h2WyuPQq4aRb0ZewVdD+ KAvgGJpxbG3I/sevWEj1D1WJgJwoeAnFyrbReY+g77fIm5+y04oumsy7H5D2o7rRaok8BwmCl8BO5 vkylPHqjXvqdxCEftCG30z4rRmIZR4QsOo6AjNYU57bb8vlbehVj5XD04t69olDA25xuBlynxtqpM ZQ2kiMK0xAcWDJd3JlCfMIzLXA05UEQFrJO25iWIVExJEpzJagl2jE4n8py/B5YOdC2t8F+4ZY7+y WSNLZT6cdlG2S5LjrK+Bvw==; In-Reply-To: <435f03489dab91624a0d60f57b0ed698@finder.org> (message from Jared Finder on Sat, 08 Jun 2024 17:29:15 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286939 Archived-At: > Date: Sat, 08 Jun 2024 17:29:15 -0700 > From: Jared Finder > Cc: juri@linkov.net, 68765@debbugs.gnu.org, philipk@posteo.net, > monnier@iro.umontreal.ca > > > This LGTM, with one comment: you mention in the section about window > > tool bars that it cannot be shown if a tab line is shown in the > > window, but you don't have a similar caveat in the section about tab > > lines. I think we should add a similar caveat there as well. > > Patch attached for updated manual, NEWS, and changes to > window-tool-bar.el. This also extends support back to Emacs 27 in the > package as requested earlier in this thread. Thanks, installed on the master branch, and closing the bug.