From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71562: treesit-install-language-grammar fails to install typescript Date: Wed, 19 Jun 2024 22:14:34 +0300 Message-ID: <86wmmkoicl.fsf@gnu.org> References: <87v82bcrrm.fsf@dod.no> <47399af2-6982-4ce1-ad50-db426624edae@gutov.dev> <86msnmwwbk.fsf@gnu.org> <93d76485-2563-45e3-890d-d5bfc56ff4b7@gutov.dev> <86v829sc18.fsf@gnu.org> <87le30bwba.fsf@dod.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1356"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, casouri@gmail.com, 71562@debbugs.gnu.org To: Steinar Bang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 19 21:15:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sK0m4-0000AT-Su for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Jun 2024 21:15:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sK0lp-0001Qw-PF; Wed, 19 Jun 2024 15:15:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sK0ln-0001Qi-U4 for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 15:15:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sK0ln-0008El-Fx for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 15:14:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sK0lq-0004Ra-Hg for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 15:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71562 X-GNU-PR-Package: emacs Original-Received: via spool by 71562-submit@debbugs.gnu.org id=B71562.171882449117036 (code B ref 71562); Wed, 19 Jun 2024 19:15:02 +0000 Original-Received: (at 71562) by debbugs.gnu.org; 19 Jun 2024 19:14:51 +0000 Original-Received: from localhost ([127.0.0.1]:55782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK0le-0004Qi-V0 for submit@debbugs.gnu.org; Wed, 19 Jun 2024 15:14:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK0lc-0004QL-MJ for 71562@debbugs.gnu.org; Wed, 19 Jun 2024 15:14:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sK0lR-0008CK-2I; Wed, 19 Jun 2024 15:14:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Aw7VMShERH3gxvSZNq8Ozms7f8jJazpDtvANJWFY07o=; b=V/4lpmpEGSayOuVupEE+ sYsWTGD5neghvl9MUNMoo/277C9ON+gxL6CzAVTPa2JpFHbNV1w2ISH82mWp/Om/CTsF4E4Hw6Sq8 wpoSup2FM6Ssm/u3EQktktpOb4dJ43VEI0Mh/pnbhboG1DtBAkxvP3zVZPwHoP2H18HjyQhyLFPQQ IydMigpERyd+CWqDY3DpNAylb1h3oUp/29QCPqMVuN6ctnqYpzujmrJZpivVW6IFjJUqdYLWWGnSL ImzZb8KzBfKu0Lal5vYLLguxaZoOgp0tMjsfNpzdrd1UwVSAAROcrUwL5760d6w327Vkh/1OZNkrL 3TllzGwe8NAtew==; In-Reply-To: <87le30bwba.fsf@dod.no> (message from Steinar Bang on Wed, 19 Jun 2024 20:51:21 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287501 Archived-At: > From: Steinar Bang > Cc: Eli Zaretskii , Dmitry Gutov , > 71562@debbugs.gnu.org > Date: Wed, 19 Jun 2024 20:51:21 +0200 > > >>>>> Yuan Fu : > > > treesit-install-language-grammar works fine if you pass “typescript/src” instead of the default “src” to it, for the third argument, so I don’t think there’s anything to fix here. Installing multiple things “smartly” might be more confusing and error-prone than helpful, IMO. > > FWIW the repo contains two grammars: typescript and tsx > > And both grammars are needed (not just typescript). Yes. Which is why I said that we should find _all_ the subdirectories called 'src' which have a parser, and produce a shared library in each one of them.