From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71644: 30.0.50; Severe slowdown in larger files with markers beginning in emacs 29+ Date: Sat, 22 Jun 2024 21:17:36 +0300 Message-ID: <86wmmgg7un.fsf@gnu.org> References: <86ed8tozub.fsf@gnu.org> <86jzijmo5a.fsf@gnu.org> <86y16ylrj9.fsf@gnu.org> <86ed8pjwgc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34160"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 71644@debbugs.gnu.org To: Mitchell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 20:18:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sL5Jc-0008hX-DV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 20:18:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sL5JL-0005IM-N0; Sat, 22 Jun 2024 14:18:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL5JK-0005I3-MP for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 14:18:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sL5JK-0002Ia-ES for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 14:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sL5JK-0007HE-A9 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 14:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 18:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71644 X-GNU-PR-Package: emacs Original-Received: via spool by 71644-submit@debbugs.gnu.org id=B71644.171908026627943 (code B ref 71644); Sat, 22 Jun 2024 18:18:02 +0000 Original-Received: (at 71644) by debbugs.gnu.org; 22 Jun 2024 18:17:46 +0000 Original-Received: from localhost ([127.0.0.1]:55381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL5J4-0007Gb-Cy for submit@debbugs.gnu.org; Sat, 22 Jun 2024 14:17:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL5J2-0007GN-AB for 71644@debbugs.gnu.org; Sat, 22 Jun 2024 14:17:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL5Iw-000299-S6; Sat, 22 Jun 2024 14:17:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zyqRqHqywKk9x2n1qcTUtLefRiYgAdhsul7bpXdXR8o=; b=eH66Q80NKkfA/u9wHBBK GbJADyy188Ac1ZuxwkZH6KLJgyI8cZm2j7CXjKQF+WfqT2ja54DwIVx6UjvvuSmkEHjJTkaqpzn8n xo8YCSE0WA44nopSztaaedtucdAtRVFlxuOe7beYZ+sASemqEUNAZZtoMbSIp/RCXgHIHikMCfJoH vvoGRBObzqTZmJCNZdeUq24h+gPUt2z47TlyJFIu0N1crwYE0bC1YY42peQ4hxHlOF8fHZbHC19KP IMrj1S2wztiqhy8dOmS3xayH3alTqknmkhOVv0WxuHBo0/lqZuaLjEJQATAPB3cvknhMGv5DAB3m/ pXuERQ+hwRqXbQ==; In-Reply-To: (message from Mitchell on Sat, 22 Jun 2024 12:03:05 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287730 Archived-At: > From: Mitchell > Date: Sat, 22 Jun 2024 12:03:05 -0600 > Cc: Stefan Monnier , 71644@debbugs.gnu.org > > On Sat, Jun 22, 2024 at 12:58 AM Eli Zaretskii wrote: > > > > From: Stefan Monnier > > > Cc: Mitchell , 71644@debbugs.gnu.org > > > Date: Fri, 21 Jun 2024 17:06:31 -0400 > > > > > > > commit 8783700b23e70874c4996908bf02c010ae6f3fe1 > > > > Author: Stefan Monnier > > > > AuthorDate: Tue Aug 2 10:38:53 2022 -0400 > > > > Commit: Stefan Monnier > > > > CommitDate: Tue Aug 2 13:06:51 2022 -0400 > > > > > > > > * src/xdisp.c (redisplay_window): Use BEG rather than hard coding 1 > > > > > > > > It changed the comparison operator in two places in marker.c. > > > > > > > > Curiously, the log message doesn't even mention the change in > > > > marker.c, which could be a sign that this change was not intended to > > > > be installed. Stefan, did you intend to install it, and if so, do you > > > > have any comments about this bug report? > > > > > > Hmm... can't remember why/how it ended up in the above commit. > > > Looks like an oversight. But the change should be harmless: the > > > `eassert` should make sure that the comparison gives the same answer > > > either way (and AFAICT if/when the new comparison gives a different > > > answer from the old code, the old code will loop until it segfaults). > > > > Mitchell, can you try reverting that change, and see if that affects > > performance in your case? > > Eli, after Ihor and Stefan were able to reproduce it now, would it still be helpful for me to do this and report > back? I’m more than happy to if it would help in any way. Yes, because we still don't understand well why performance regressed from Emacs 28 to Emacs 29. > Also should I be replying to the renamed thread from now on? (i.e., "chars==bytes (was: bug#71644: 30.0.50; > Severe slowdown in larger files with markers beginning in emacs 29+") This is my first bug report, so I’m not > sure the etiquette, haha. No, please keep replying with the original Subject. That other thread was a side issue.