From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72245: [PATCH] Fix integer overflow when reading XPM Date: Tue, 23 Jul 2024 18:33:41 +0300 Message-ID: <86wmlc86ne.fsf@gnu.org> References: <87frs0ydv6.fsf@yahoo.com> <87bk2oyavb.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33110"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 72245@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 23 17:35:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWHY0-0008LT-Hm for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jul 2024 17:35:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWHXY-0006tv-1n; Tue, 23 Jul 2024 11:35:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWHXW-0006tY-0D for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 11:34:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWHXV-0005mW-OE for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 11:34:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWHXa-0002By-3Z for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 11:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2024 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72245-submit@debbugs.gnu.org id=B72245.17217488468352 (code B ref 72245); Tue, 23 Jul 2024 15:35:02 +0000 Original-Received: (at 72245) by debbugs.gnu.org; 23 Jul 2024 15:34:06 +0000 Original-Received: from localhost ([127.0.0.1]:60568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWHWg-0002Ae-4E for submit@debbugs.gnu.org; Tue, 23 Jul 2024 11:34:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWHWb-0002A4-FU for 72245@debbugs.gnu.org; Tue, 23 Jul 2024 11:34:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWHWR-0005es-HK; Tue, 23 Jul 2024 11:33:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bUfo88ym+pftAFdJomKx2ize84NtwJkxZoIExj+BPic=; b=E714PDQDyJWP qbzG3wGyyI5NC8ChXMux+/gg9f+I0Cq5TCcOlz8cTc/3mdWHvxlM2VOVguq8pECGHBa0UwPGkuYa3 J/j8ZuhXZ7+eh70RHCrtLYefNZ8UO9B139t9JZl3oSXiNU4xBBh73txvMklh8VVe+ZTKw+Nlpzgge KFulgZB3RtIgF9skVfK3ddkhAX2OYQPX/zU7mqtIQaRn5e3v96Oc8vWe6c+J1zOuVhTS0KvxWJXov ljXlP3JXX6wrjF5j2wqA5asSDx9Ct0yYO+BucVAD/6l7Y6eyWA/iL4kyBR68feDugnqVQg9Jg6dTo T0QAvIz4gh/CPF3j4ZHBEw==; In-Reply-To: (message from Stefan Kangas on Tue, 23 Jul 2024 07:51:29 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289175 Archived-At: > Cc: 72245@debbugs.gnu.org > From: Stefan Kangas > Date: Tue, 23 Jul 2024 07:51:29 -0700 > > That said, since you are asking, we are indeed discussing security > sensitive code, that is executed without prompting, for example, when > users receive emails or browse the web. Only in some MUAs, yes? For example, Rmail doesn't by default show the images (or any other attachments), it requires a user action to do so. > XPM being a relatively simple format, I'm sure that this code can be > fully audited. I invite you to do so, and I'm hoping that this will > reveal that your faith in this code is well-founded. Meanwhile, I > reported an unrelated crash in XPM image processing in Bug#72255. That file doesn't cause a crash on MS-Windows, FWIW, but the code which processes XPM images in Emacs on Windows is very different.