From: Eli Zaretskii <eliz@gnu.org>
To: Troy Brown <brownts@troybrown.dev>, joaotavora@gmail.com
Cc: 72597@debbugs.gnu.org, felician.nemeth@gmail.com
Subject: bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return
Date: Sat, 31 Aug 2024 10:55:44 +0300 [thread overview]
Message-ID: <86wmjxcein.fsf@gnu.org> (raw)
In-Reply-To: <CABvCZ43nfhPQYyGpw92tQQ0JrjCD+TDN+dY3gf6BqLd9QyGJqg@mail.gmail.com> (message from Troy Brown on Wed, 14 Aug 2024 07:41:36 -0400)
Ping! How can we make progress with this issue?
> From: Troy Brown <brownts@troybrown.dev>
> Date: Wed, 14 Aug 2024 07:41:36 -0400
> Cc: Felician Nemeth <felician.nemeth@gmail.com>, joaotavora@gmail.com, 72597@debbugs.gnu.org
>
> On Wed, Aug 14, 2024 at 2:37 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > > From: Felician Nemeth <felician.nemeth@gmail.com>
> > > Cc: Troy Brown <brownts@troybrown.dev>, joaotavora@gmail.com,
> > > 72597@debbugs.gnu.org
> > > Date: Wed, 14 Aug 2024 07:54:24 +0200
> > >
> > > Eli Zaretskii <eliz@gnu.org> writes:
> > >
> > > > Can you please answer my question whether this is standard-complying
> > > > behavior according to LSP protocol? IOW, what is the source of the
> > > > assumption that CR characters will be interpreted as newlines in these
> > > > cases?
> > >
> > > It seems this is standard-complying, because the specification has this:
> > > "To ensure that both client and server split the string into the same
> > > line representation the protocol specifies the following end-of-line
> > > sequences: ‘\n’, ‘\r\n’ and ‘\r’."
> >
> > This just caters to the 3 known EOL formats: the Unix, the
> > DOS/Windows, and the Mac one. If this is the basis for the described
> > behavior, then Emacs should bind coding-system-for-read when reading
> > this stuff, or maybe manually decode the strings after detecting EOL
> > format. But that would only work if the EOL format is used
> > consistently in the entire response of the server; if they just use
> > the above as a means to sneak in multiple-line responses, and
> > otherwise use some other EOL format, then we need to handle a lone \r
> > specially in Eglot's code, something I'm not sure we like to do.
>
> Other than what Felician already quoted from the LSP specification,
> there doesn't seem to be much else stated about EOL. In this
> particular case, I've seen it on both Linux and Windows, therefore the
> use of the CR doesn't seem to be consistent with the platform or the
> document format. It's unclear to me why this particular EOL format
> was chosen for the hover information, but I can't find anything in the
> specification that says it is incorrect.
>
next prev parent reply other threads:[~2024-08-31 7:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 1:16 bug#72597: 30.0.60; Eglot: MarkedString with embedded Carriage Return Troy Brown
2024-08-13 11:18 ` Eli Zaretskii
2024-08-13 18:32 ` Felician Nemeth
2024-08-13 18:45 ` João Távora
2024-08-13 21:35 ` Troy Brown
2024-08-14 4:37 ` Eli Zaretskii
2024-08-14 5:54 ` Felician Nemeth
2024-08-14 6:37 ` Eli Zaretskii
2024-08-14 11:41 ` Troy Brown
2024-08-31 7:55 ` Eli Zaretskii [this message]
2024-09-01 20:49 ` Troy Brown
2024-09-02 11:24 ` Eli Zaretskii
2024-09-02 12:31 ` João Távora
2024-09-05 21:32 ` Daniel Pettersson
2024-09-05 21:58 ` João Távora
2024-09-06 5:44 ` Eli Zaretskii
2024-09-06 16:00 ` Daniel Pettersson
2024-09-06 19:31 ` João Távora
2024-09-09 0:31 ` Troy Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wmjxcein.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72597@debbugs.gnu.org \
--cc=brownts@troybrown.dev \
--cc=felician.nemeth@gmail.com \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).