From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74413: [PATCH] Allow to store and read repository information of VCS builds Date: Tue, 19 Nov 2024 17:16:33 +0200 Message-ID: <86wmgztfse.fsf@gnu.org> References: <86frnovhg8.fsf@gnu.org> <867c90vbfk.fsf@gnu.org> <861pz8uzyo.fsf@gnu.org> <86zflwtjlz.fsf@gnu.org> <87y11g5i2x.fsf@> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21186"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 74413@debbugs.gnu.org, stefankangas@gmail.com To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 19 16:19:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDQ0a-0005Lx-F0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Nov 2024 16:19:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDQ0R-0001HK-7M; Tue, 19 Nov 2024 10:19:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDQ0N-0001GQ-FY for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 10:19:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDQ0M-000604-Vx for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 10:19:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=d7kPo19Z7emfvEn6eVoqh+ITcM1ifOzXUOPMIOgWzhg=; b=O/3eRsmFMUTiaLMSqtzReYkMdsYl48yuG+Y23X+vTNX4S8M5X1Ih7b10u4993DAT7Zgibad0bKeX/WrKXYmzpwdqRE+TRSs6WyssSReLJeVcMulMVsDNHhSE2TyM6OIdUPAHWlgndLuHAOXVpMQyy6vdlQCbvCBrGl/igretqsamqYPwpS2fKxJtCvdvb9s5NbKNMdbq1gXvjy4QR+awvByNiwf0hFnkj2IAVelEffjKxJPXcFyMILWcFGda9FFn92o2AM68SRsVt/U46LJNWIo7/yQ8XqPKjWCP6AgHgNxn0nydJ6oFPDXsOFzU2fif3BtHSUaI7FoQRwE0O1NcJQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDQ0M-000379-0G for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 10:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2024 15:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74413-submit@debbugs.gnu.org id=B74413.173202953611958 (code B ref 74413); Tue, 19 Nov 2024 15:19:01 +0000 Original-Received: (at 74413) by debbugs.gnu.org; 19 Nov 2024 15:18:56 +0000 Original-Received: from localhost ([127.0.0.1]:43649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDQ0F-00036n-K1 for submit@debbugs.gnu.org; Tue, 19 Nov 2024 10:18:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDQ0D-00036a-AF for 74413@debbugs.gnu.org; Tue, 19 Nov 2024 10:18:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDPy0-0005ZT-J5; Tue, 19 Nov 2024 10:16:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=d7kPo19Z7emfvEn6eVoqh+ITcM1ifOzXUOPMIOgWzhg=; b=Bdg442JGEDvNcRzibyIp mpS0U+92eojmazarfEWIADVcepJSFtWbKXko34LlRXyhNhcHKeahDclYndogXPvBTiw097txnR/h/ /dRXNxLMua1fMGpCp/VV0m0c/8vsfSNTI/eqLi68P56zOixnbGNH+3c1eskFx8db2zbkhrRYvj27X U03rH/jfCkcc8yqbM3282aA5kykbUcoNpS/mpbtiQWezByUJflV18rT2/YKL/J1B2e0hzjDIP+IsR kkqRTl4l4X3Q9GE6CHuhb/TzTcx6WOPaYjpefO1IkXIBSL9kYa315bDHV7hNm4Vhmd7SLb1jK27kJ bGQucXRa+0eMmw==; In-Reply-To: <87y11g5i2x.fsf@> (message from =?UTF-8?Q?Bj=C3=B6rn?= Bidar on Mon, 18 Nov 2024 23:48:38 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295636 Archived-At: > From: Björn Bidar > Cc: stefankangas@gmail.com, luangruo@yahoo.com, 74413@debbugs.gnu.org > Date: Mon, 18 Nov 2024 23:48:38 +0200 > > Eli Zaretskii writes: > > > I still don't think I understand, sorry. Do you mean the file is > > generated from a Git repository, but then Emacs is somehow built from > > a directory that is not under Git? > > The file can be generated from the git repository outside of the Emacs > builder. So you mean someone will chdir to the Git repository, say $ make etc-emacsver Then take the produced file and manually install it when Emacs is built (in another directory) and installed, is that right? > > But if this is the scenario, how can you be sure the produced Emacs binary was made from that revision > > on that branch? This is only guaranteed if you actually build from > > Git when you record this information. > > > > What am I missing? > > If the source is generated by the CI it can also store this information > in the build source which then can be extracted from the ci metadata to > the Emacs sources on the builder. > > I can be sure that Emacs was built from that revision as much as I can > trust the CI to use the sources I told it to use. If I can't trust one, > I can't trust the other. But CI builds from Git, doesn't it? If so, the Emacs it produces already records the revision and the branch.