From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Tue, 24 Dec 2024 05:30:31 +0200 Message-ID: <86wmfp3gh4.fsf@gnu.org> References: <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> <86r06jgv1j.fsf@gnu.org> <86jzcafcj6.fsf@gnu.org> <867c8af514.fsf@gnu.org> <86ldwpedud.fsf@gnu.org> <86r05z67gm.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27567"; mail-complaints-to="usenet@ciao.gmane.io" Cc: trevor.m.murphy@gmail.com, yantar92@posteo.net, me@eshelyaron.com, monnier@iro.umontreal.ca, 73862@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 24 04:31:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPvdd-00070Z-Fi for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Dec 2024 04:31:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPvdS-00011j-UA; Mon, 23 Dec 2024 22:31:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPvdP-00011A-6w for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 22:31:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPvdO-0006jk-Nr for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 22:31:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=rh5o3D2qZPlMJTU6kLayT2parO98P8a7y2LN47rB8kM=; b=M3FbMVDFbM84sMkVqrBmOlAkQSJka0mrtlFgxyj2XhDBeSp5OCppIRgRwYvn07Stjk+FNSjfGYeeVho3q2YzlNJStzMW3WePD7mLzevZC8iTAL5UTtn13p+NiGcmJicanwzNppNGVqUqDEx5qfvMu+2UfJGYGv+0ywY0ed9SwDNP44PV4e0PH8X7B9vLSEgbEplHFnGxSxi+96y31s3iCUCxzxC1k9O2uoM39VpQSFSbxycMET7GWa1N7m0h1XB5lquq7eWvBcY8TRJZPiAVndYnVH9uUTrqAxD+3nZRwqiItuiaUNqyUZwxyaVTSzNbVo2ynkm+QoFiLbU8yLvCQg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPvdO-0004lB-I7 for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 22:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2024 03:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173501104518267 (code B ref 73862); Tue, 24 Dec 2024 03:31:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 24 Dec 2024 03:30:45 +0000 Original-Received: from localhost ([127.0.0.1]:58875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPvd6-0004kZ-GF for submit@debbugs.gnu.org; Mon, 23 Dec 2024 22:30:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPvd4-0004kN-Lx for 73862@debbugs.gnu.org; Mon, 23 Dec 2024 22:30:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPvcy-0006iJ-GY; Mon, 23 Dec 2024 22:30:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rh5o3D2qZPlMJTU6kLayT2parO98P8a7y2LN47rB8kM=; b=VxcpBT35qSGa THp2YIrWUxQFJhv1CcuKqidCUjvNsSJFHqIkU4lqr2DVGTJ1/1zjnn6Lg8IoYv6kvsrGMiCp7H4Uz /ZQmQ6odBusYcJicUiqlwqykjC979Y2TLcQQPbHNtfDWDb3pbp+hsZnDAH51yNzPorb9LYMo5degU RI21vcS9PdC5NAr03uxnImHo2DRy+Zc30qZnN0L3d03rs/hfk4wzs1mbN9yoze8gwd9zsVQX1FOH6 WVbic63hdvqH8U0TC8TvB0m4/mbC9h+K4HRF8o/ggswFYQss64Vl6eqZhmKjD0k8pr6wvr3i3rOGn getbu+MjAdrE4qLTQG0Zww==; In-Reply-To: (message from Aaron Jensen on Mon, 23 Dec 2024 13:19:32 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297681 Archived-At: > From: Aaron Jensen > Date: Mon, 23 Dec 2024 13:19:32 -0800 > Cc: Eli Zaretskii , trevor.m.murphy@gmail.com, monnier@iro.umontreal.ca, > 73862@debbugs.gnu.org, yantar92@posteo.net > > On Mon, Dec 23, 2024 at 2:20 AM, Eshel Yaron wrote: > > Eli Zaretskii writes: > > Please try the patch below. If it gives good results, please run with it for awhile, and tell if you see > anything unusual or unexpected. > > Thanks, so far so good. > > Same for me, it's also working so far. > > Are there any tradeoffs with this approach other than additional code complexity? Any performance > concerns? I didn't time the code. It is a bit more expensive, but I don't know by how much. Maybe you could see what happens in a session with lots and lots of faces and report?