unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: trevor.m.murphy@gmail.com, yantar92@posteo.net,
	me@eshelyaron.com, monnier@iro.umontreal.ca,
	73862@debbugs.gnu.org
Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces.
Date: Tue, 24 Dec 2024 05:30:31 +0200	[thread overview]
Message-ID: <86wmfp3gh4.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48wsCFA3Ka9-giBJ3U7CtTOTmWLXuO3TG91QZY9gdpX84Q@mail.gmail.com> (message from Aaron Jensen on Mon, 23 Dec 2024 13:19:32 -0800)

> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Mon, 23 Dec 2024 13:19:32 -0800
> Cc: Eli Zaretskii <eliz@gnu.org>, trevor.m.murphy@gmail.com, monnier@iro.umontreal.ca, 
> 	73862@debbugs.gnu.org, yantar92@posteo.net
> 
> On Mon, Dec 23, 2024 at 2:20 AM, Eshel Yaron <me@eshelyaron.com> wrote:
> 
>  Eli Zaretskii <eliz@gnu.org> writes: 
> 
>  Please try the patch below. If it gives good results, please run with it for awhile, and tell if you see
>  anything unusual or unexpected. 
> 
>  Thanks, so far so good.
> 
> Same for me, it's also working so far.
> 
> Are there any tradeoffs with this approach other than additional code complexity? Any performance
> concerns?

I didn't time the code.  It is a bit more expensive, but I don't know
by how much.  Maybe you could see what happens in a session with lots
and lots of faces and report?





  reply	other threads:[~2024-12-24  3:30 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 12:56 bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces trevor.m.murphy
2024-10-27 10:46 ` Eli Zaretskii
2024-11-09  9:37   ` Eli Zaretskii
2024-11-11  6:11     ` Trevor Murphy
2024-11-16 14:11       ` Eli Zaretskii
2024-12-04  5:06 ` Aaron Jensen
2024-12-04  6:30   ` Aaron Jensen
2024-12-04 13:49     ` Eli Zaretskii
2024-12-05  3:06       ` Aaron Jensen
2024-12-05  6:22         ` Eli Zaretskii
2024-12-05  6:50           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-05  7:31             ` Eli Zaretskii
2024-12-05  6:53           ` Aaron Jensen
2024-12-05  7:29             ` Aaron Jensen
2024-12-05  7:51               ` Eli Zaretskii
2024-12-05 16:02                 ` Aaron Jensen
2024-12-05 20:42                   ` Eli Zaretskii
2024-12-05 21:14                     ` Aaron Jensen
2024-12-06  8:55                       ` Eli Zaretskii
2024-12-06 14:53                         ` Aaron Jensen
2024-12-06 16:28                           ` Aaron Jensen
2024-12-07  9:54                             ` Eli Zaretskii
2024-12-07  9:50                     ` Eli Zaretskii
2024-12-07 13:28                       ` Aaron Jensen
2024-12-07 15:02                         ` Eli Zaretskii
2024-12-07 17:13                           ` Aaron Jensen
2024-12-07 18:25                             ` Eli Zaretskii
2024-12-07 18:46                               ` Aaron Jensen
2024-12-07 18:59                                 ` Eli Zaretskii
2024-12-07 19:06                                   ` Aaron Jensen
2024-12-07 19:19                                     ` Eli Zaretskii
2024-12-07 19:59                                       ` Aaron Jensen
2024-12-08 14:11                                       ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-08 14:57                                         ` Eli Zaretskii
2024-12-08 16:29                                           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-08 17:26                                             ` Aaron Jensen
2024-12-08 17:39                                             ` Eli Zaretskii
2024-12-08 20:56                                               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-09  3:26                                                 ` Eli Zaretskii
2024-12-09  8:56                                                   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-14  9:45                                                     ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22 15:52                                                       ` Eli Zaretskii
     [not found]                                                         ` <m1r05yk8e4.fsf@macbookpro.home>
2024-12-23 21:19                                                           ` Aaron Jensen
2024-12-24  3:30                                                             ` Eli Zaretskii [this message]
2024-12-24  5:17                                                               ` Aaron Jensen
2024-12-24 12:44                                                                 ` Eli Zaretskii
2024-12-05  7:35             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wmfp3gh4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=73862@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=me@eshelyaron.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=trevor.m.murphy@gmail.com \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).