From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75018: 30.0.93; Dired icon missing in tool-bar Date: Sat, 28 Dec 2024 13:56:08 +0200 Message-ID: <86wmfkrpgn.fsf@gnu.org> References: <87o714r2ky.fsf@pub.pink> <86bjx46wvs.fsf@gnu.org> <6bfb0822-f2e9-48d5-bcf3-0012fc432782@app.fastmail.com> <86msgn6582.fsf@gnu.org> <871pxzijsx.fsf@pub.pink> <87plljh4w9.fsf@pub.pink> <87wmfrfezz.fsf@pub.pink> <86wmfq4kth.fsf@gnu.org> <87ed1ygvst.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23355"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75018-done@debbugs.gnu.org To: john muhl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 28 12:57:44 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRVRw-0005tl-7d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Dec 2024 12:57:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRVRN-00023I-7h; Sat, 28 Dec 2024 06:57:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVRK-00020I-Gs for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 06:57:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRVRK-0006C0-7a for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 06:57:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=yduL4jgCQjbnGL8zlqrXkofWuhdmOA4wRJvw3d49r98=; b=U6IDKFVi/VrZFqfp75oh0LnUhxVtZtpGeg90a2KV8Dyf4vRBYNvGt8jFbhoXsOf2thsIQftDxeSNVr3q0+KBp5dbz/6wfRC1OgEAmaGzvuAmaXiwGMvYjM6Sz16EtKjHiT0+RK7RMdmpfI96kckAoTIzno1Ss+4WrswDoFOPQj/eHanhlO4rmPp76iHK44RfHPDXct+iIsRWdYMW8VVVueHLFss5ygtfu6atZHyVPko+d2XA9FxJM0w29KV343YhiqpLJKl8HZ6wQNovwpe3LGtGWAK6aJcsGz0eiByniEUXY+4F+hVE2fNpy2dbzp8wFSMx93Npo2yfYIgBpDCuUA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRVRK-0000sW-0U for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 06:57:06 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Dec 2024 11:57:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 75018 X-GNU-PR-Package: emacs Mail-Followup-To: 75018@debbugs.gnu.org, eliz@gnu.org, jm@pub.pink Original-Received: via spool by 75018-done@debbugs.gnu.org id=D75018.17353869853227 (code D ref 75018); Sat, 28 Dec 2024 11:57:05 +0000 Original-Received: (at 75018-done) by debbugs.gnu.org; 28 Dec 2024 11:56:25 +0000 Original-Received: from localhost ([127.0.0.1]:49572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRVQe-0000py-Lx for submit@debbugs.gnu.org; Sat, 28 Dec 2024 06:56:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRVQZ-0000pP-5S for 75018-done@debbugs.gnu.org; Sat, 28 Dec 2024 06:56:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVQS-00064A-85; Sat, 28 Dec 2024 06:56:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=yduL4jgCQjbnGL8zlqrXkofWuhdmOA4wRJvw3d49r98=; b=ebDfv7ZLyrTksUYZgrSp sJ36J85Y6I/xJs5cYY/xDPC5sjPpJ6g7NhAaNU21BowClzyUnLt0Rw7YOO+ZOcgoCUetrnykFxobL EiwRamrAIhcxD2rC+D/jt6pmaD9preV6lVclTtEjiXQGfnM/J+rch5BCaJDJY0txRMT2S6UFs+WTD w4gAcjHsXI2mOI9xEtqggrwBhvgyZJ7gw+xeOPzPni3MhkXVHCkpM58NJW7CByymyMiy73u3hN84q LXnZjNM/jOXQdWy6/9ZthPdEZXzVeWucjS4BWFWI3GLCCwI8WTOw0aql4MrNEcWMPJI1SuBtpHND+ +GIYyyY3Y0K2/A==; In-Reply-To: <87ed1ygvst.fsf@pub.pink> (message from john muhl on Mon, 23 Dec 2024 11:21:06 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297891 Archived-At: > From: john muhl > Cc: 75018@debbugs.gnu.org > Date: Mon, 23 Dec 2024 11:21:06 -0600 > > Eli Zaretskii writes: > > >> From: john muhl > >> Cc: 75018@debbugs.gnu.org > >> Date: Sun, 22 Dec 2024 17:57:04 -0600 > >> > >> The following gets all the icons working: > >> > >> dnf install gdk-pixbuf2-modules-extra > >> > >> Maybe something to mention PROBLEMS? Feel free to close unless you > >> think there anything else to investigate. > > > > I'm okay with having a PROBLEMS entry about this, but I'd be much > > happier if I understood some more about the problem. How does > > installing those icons solve the problem? Is the problem caused by > > absence of some icons, and the strange display is just an indication > > that the file is missing? > > The gdk-pixbuf2-modules-extra package doesn’t install any > icons. It installs support for loading additional image formats: > > This package contains modules for loading ANI, BMP, ICNS, ICO, > PNM, QTIF, TGA, XBM, and XPM images. > > What appears to have happened is that the loaders for these > formats were removed from the main GDK packages in Fedora 41 thus > any attempt to load an XPM fails (in Emacs and all other > programs). Why the developers decided to use those strange icons > in case of failure is unclear and probably beyond my investigative > abilities. > > Ultimately Fedora needs to fix their Emacs package so that > gdk-pixbuf2-modules-extra is listed among the dependencies. Does > Emacs have any connections there we could reach out to? If not I > can send bug report. > > > And what, if anything, should we do with the patch you posted a few > > messages ago? is it also needed? > > It is not needed but users of the GTK builds might find it an > improvement as it makes Dired match the style of their system’s > icon theme. Maybe we could try it on master and be ready to revert > if it proves unwelcome. The attached image shows the current > situation on top and the patched version below. > > However, a non-exhaustive search of the archives didn’t turn up > any complaints about the current state so maybe everyone is happy > enough as is…or has the tool-bar disabled, doesn’t care and it’s > not even worth the effort to test it on master. > > FTR: I do use the tool-bar all the time on GUI frames and find the > mismash of icon styles very mildly annoying. > > > If it is not needed after installing > > gdk-pixbuf2-modules-extra, then how did that patch solve the problem > > without the icons? > > The patch “fixed” it by mapping etc/images/diropen to a system > icon (part of the stock icons and already available by default) > which meant that it wouldn’t try to fallback on > etc/images/diropen.xpm. Therefore it wouldn’t run into the issue > of the missing XPM loader that is part of the > gdk-pixbuf2-modules-extra package. > > The patch does nothing for all the other missing icons I mentioned > (message-mode, Info &c.). Installing the package of extra loaders > fixes all those as they are once again able to load from the > etc/images/*.xpm files. > > > IOW, this issue is still some black magic to me, and I'd like the > > mystery be lifted. > > > > Thanks. > > I hope that it’s at least a little less mysterious now. OK, thanks. I've now added a PROBLEMS entry about this on the emacs-20 release branch, and I'm therefore closing this bug.