From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.bugs Subject: bug#48535: 28.0.50; ff-find-other-file no longer sets current-buffer? Date: Fri, 21 May 2021 14:09:44 -0700 Message-ID: <86v97byesn.fsf_-_@stephe-leake.org> References: <86fsyhzh6a.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30441"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt) To: 48535@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 21 23:10:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lkCPJ-0007cj-Tk for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 May 2021 23:10:10 +0200 Original-Received: from localhost ([::1]:37274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkCPI-00027j-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 May 2021 17:10:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkCPD-00027X-0Q for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 17:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkCPC-00012v-Ow for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 17:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lkCPC-0003fD-J4 for bug-gnu-emacs@gnu.org; Fri, 21 May 2021 17:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 May 2021 21:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48535 X-GNU-PR-Package: emacs Original-Received: via spool by 48535-submit@debbugs.gnu.org id=B48535.162163140014069 (code B ref 48535); Fri, 21 May 2021 21:10:02 +0000 Original-Received: (at 48535) by debbugs.gnu.org; 21 May 2021 21:10:00 +0000 Original-Received: from localhost ([127.0.0.1]:37882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkCP9-0003er-Oc for submit@debbugs.gnu.org; Fri, 21 May 2021 17:09:59 -0400 Original-Received: from gateway34.websitewelcome.com ([192.185.148.119]:16568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkCP6-0003ei-M8 for 48535@debbugs.gnu.org; Fri, 21 May 2021 17:09:58 -0400 Original-Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id B71A1721B81 for <48535@debbugs.gnu.org>; Fri, 21 May 2021 16:09:50 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id kCOzlsW5m8uM0kCOzl73id; Fri, 21 May 2021 16:09:50 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CtMAfY6QdRaPe+EdNMTUALwPC02hQu64DpZjjR1ev3s=; b=lnW5GI7c6gYbLFtjp5qJfh5fi0 W5Ru+pjkbPD+VyD44nq8DCqnMwlwFrF8KWLZMFn7MAH1aMM/4vW73ECbtinKID4WPhNABrY6d8Qt9 4796p1Hsu8I0u7AdZHO5DvSqrHxDQq58rk9DL6dfiLsglPEn5v9NphBJfV0R8BtH1P0x6/owV5Unu meZ4LeG3F+CgWMoKjwa51yeINb7jaWx72QpDQPg2YE1ErU2L53RiJZu2jJgAUfOt0BGje6yv4vUOn fPNhiEKOZuaSdRJC3+YZUBcz0LM88wm/BAPQXuuPbNVMUpZ1F8451wHjhNt3sTWHCQ1uFV4+6T8e3 Me6ATjiA==; Original-Received: from [76.77.182.20] (port=55259 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lkCOz-003Dve-Cm for 48535@debbugs.gnu.org; Fri, 21 May 2021 15:09:49 -0600 In-Reply-To: (GNU bug Tracking System's message of "Thu, 20 May 2021 13:09:02 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1lkCOz-003Dve-Cm X-Source-Sender: (Takver4) [76.77.182.20]:55259 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207004 Archived-At: This breaks emacs ada-mode automated tests, which rely on evaluating elisp forms in Ada comments. git bisect says this commit is to blame: commit: c105017c44d4a679f7af739b2c0390b2c7850569 Author: Stefan Monnier Date: Tue Apr 6 17:06:07 2021 -0400 * lisp/find-file.el: Make the commands oblivious to mouse/non-mouse (ff-find-other-file): Add `event` argument. (ff-find-other-file-other-window): Rename from `ff-mouse-find-other-file-other-window` and use this new argument. (ff-mouse-find-other-file, ff-mouse-find-other-file-other-window): Make them obsolete aliases. (ff-upcase-p): Remove unused `start` and `end` arguments and simplify accordingly. I looked thru the diff, but I didn't see anything obvious, so I'm blaming the lexical-binding change. But I don't know how to fix it. I've confirmed that disabling lexical-binding fixes the problem. -- -- Stephe