From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52769: 29.0.50; [FEATURE REQUEST] repunctuate-sentences in region Date: Tue, 28 Dec 2021 21:28:21 +0200 Organization: LINKOV.NET Message-ID: <86v8z8o7fu.fsf@mail.linkov.net> References: <86czlkld45.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35390"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52769@debbugs.gnu.org To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 28 20:32:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2ID2-000934-UQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 20:32:32 +0100 Original-Received: from localhost ([::1]:58758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2ID0-0001kG-VI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 14:32:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2ICZ-0001jT-1b for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35909) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2ICY-0003MW-Nr for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2ICY-00023k-6H for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Dec 2021 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52769 X-GNU-PR-Package: emacs Original-Received: via spool by 52769-submit@debbugs.gnu.org id=B52769.16407199187705 (code B ref 52769); Tue, 28 Dec 2021 19:32:02 +0000 Original-Received: (at 52769) by debbugs.gnu.org; 28 Dec 2021 19:31:58 +0000 Original-Received: from localhost ([127.0.0.1]:47455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2ICU-0001zy-9J for submit@debbugs.gnu.org; Tue, 28 Dec 2021 14:31:58 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:58047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2ICQ-0001tD-W2 for 52769@debbugs.gnu.org; Tue, 28 Dec 2021 14:31:56 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 98C8DE0003; Tue, 28 Dec 2021 19:31:46 +0000 (UTC) In-Reply-To: <86czlkld45.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 25 Dec 2021 21:04:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223277 Archived-At: --=-=-= Content-Type: text/plain > When I tried 'repunctuate-sentences', it stunned by its inefficiency: > it requires a confirmation even when there are already two spaces > at the end of the sentence! Why does it do this? If no one has a better idea for a simpler implementation, then this patch fixes the problem by skipping the sentences that already have two spaces at the end: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=repunctuate-sentences-filter.patch diff --git a/lisp/textmodes/paragraphs.el b/lisp/textmodes/paragraphs.el index 98362b8579..0b09895339 100644 --- a/lisp/textmodes/paragraphs.el +++ b/lisp/textmodes/paragraphs.el @@ -494,7 +494,14 @@ repunctuate-sentences (if no-query (while (re-search-forward regexp nil t) (replace-match to-string)) - (query-replace-regexp regexp to-string nil start end)))) + (let ((regexp "\\([]\"')]?\\)\\([.?!]\\)\\([]\"')]?\\)\\( +\\)") + (space-filter (lambda (_start _end) + (not (length= (match-string 4) 2))))) + (unwind-protect + (progn + (add-function :after-while isearch-filter-predicate space-filter) + (query-replace-regexp regexp to-string nil start end)) + (remove-function isearch-filter-predicate space-filter)))))) (defun backward-sentence (&optional arg) --=-=-=--