From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Willcock Newsgroups: gmane.emacs.bugs Subject: bug#44556: 27.1; Ido deletes file without configuration with C-x C-v C-k Date: Mon, 28 Feb 2022 12:44:07 +0000 Message-ID: <86v8wztb3c.fsf@precedence.co.uk> References: <87o8k4cicz.fsf@gnus.org> <87k0tr10a6.fsf@gnus.org> <86C0D40E-5DAD-452B-ACCB-C6E18E7F988D@mac.com> <87pn3ivhsz.fsf@gnus.org> <1355AD8F-2F75-419C-BB2B-F94271073D7E@mac.com> <877d9zuksf.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7935"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (windows-nt) To: 44556@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 28 13:54:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOfY2-0001o2-Q6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 13:54:42 +0100 Original-Received: from localhost ([::1]:41994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOfY1-0004f2-Nc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 07:54:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOfOh-0007YH-9a for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 07:45:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOfOg-000188-Bt for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 07:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOfOg-0004ae-8Y for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 07:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Willcock Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Feb 2022 12:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44556 X-GNU-PR-Package: emacs Original-Received: via spool by 44556-submit@debbugs.gnu.org id=B44556.164605225317570 (code B ref 44556); Mon, 28 Feb 2022 12:45:02 +0000 Original-Received: (at 44556) by debbugs.gnu.org; 28 Feb 2022 12:44:13 +0000 Original-Received: from localhost ([127.0.0.1]:60406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOfNt-0004ZJ-CW for submit@debbugs.gnu.org; Mon, 28 Feb 2022 07:44:13 -0500 Original-Received: from mail.ptlnet.com ([94.229.138.130]:65197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOfNr-0004Z8-PG for 44556@debbugs.gnu.org; Mon, 28 Feb 2022 07:44:12 -0500 Original-Received: from thinkpad.notlocalhost ([10.9.0.1]) by mail.ptlnet.com (8.16.1/8.15.2) with ESMTPS id 21SCi7DR009229 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for <44556@debbugs.gnu.org>; Mon, 28 Feb 2022 12:44:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=precedence.co.uk; s=mail; t=1646052249; bh=1aD1KLe6ac3xC9TegMHy4bX7a/zi0uzZf2+xG1mh4J8=; h=From:To:Subject:References:Date:In-Reply-To; b=HY4xmvd1CFBIz9lNOBpU2I+zlyXVHzD0akO9hDJGx8+cknBvsEL9EoA2mVEla3j32 UU7IGVZlTy2Fcudjk4NXJz6SDwFuq3ZXXZRzc/qhD0F9BYjy7UDH/sd41m183s+MjY OsRe+eN4InSXqE4YI+wjNoxT7vFxHi67Fj7LFqmI= In-Reply-To: <877d9zuksf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Feb 2022 11:24:00 +0100") X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mail.ptlnet.com [192.168.10.250]); Mon, 28 Feb 2022 12:44:09 +0000 (GMT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227796 Archived-At: Lars Ingebrigtsen writes: > Christopher Sean Morrison writes: > >> It is good to remove the malfunction from key bindings. Better is to >> remove it completely. >> >> +1 on removing it completely. That=E2=80=99s a dangerous binding consid= ering it=E2=80=99s typically >> =E2=80=9Ccut to end of line=E2=80=9D. > > I've now done this in Emacs 29. I happened across this bug report and was surprised by the end result. To state my case for a different solution: - The C-k functionality is one of the core features of ido-mode, as evidenced by the same feature being re-implemented to create fido-mode - The C-k functionality is still present in fido-mode (although it can never silently delete a file) with the same key binding active by default - ido-mode is not enabled by default and delete-by-moving-to-trash defaults to nil, therefore nothing is silently deleted by default - "Upon installing Graphene (require 'graphene) which enables Ido everywhere". Surely this is the cause of the original issue and the Graphene package is at last partially responsible for the problem? In order to keep the functionality would it be possible to revert the change but introduce a new ido-mode configuration variable? This new variable could be checked in place of delete-by-moving-to-trash to indicate that silent deleting is allowed, and the default value can prevent silent deleting unless the user enables it. This would re-align with the fido-mode operation and also protect against accidental deletions. Thanks, Morgan