From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc. Date: Mon, 04 Apr 2022 19:37:10 +0300 Organization: LINKOV.NET Message-ID: <86v8vo6c2k.fsf@mail.linkov.net> References: <87sftyweb2.fsf@gmail.com> <8635lvif0r.fsf@mail.linkov.net> <87mtidip1w.fsf@gmail.com> <86zglrl4gq.fsf@mail.linkov.net> <87ee32yk7v.fsf@gmail.com> <861qz1zqfb.fsf@mail.linkov.net> <875yod1wyb.fsf@gmail.com> <86mtho5y56.fsf@mail.linkov.net> <87sfrgz979.fsf@gmail.com> <861qz0475w.fsf@mail.linkov.net> <87sfrd2cbb.fsf@gmail.com> <86fsnc4fvm.fsf@mail.linkov.net> <878rsz6um2.fsf@gmail.com> <86ils2mmbe.fsf@mail.linkov.net> <87v8w2qsee.fsf@gmail.com> <86y20vu9c6.fsf@mail.linkov.net> <875ynt41g9.fsf@gmail.com> <86pmm1azkd.fsf@mail.linkov.net> <87a6d43c6n.fsf@gmail.com> <86r16fz6bw.fsf@mail.linkov.net> <87o81i5zzn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39856"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 53126@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 04 18:39:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbPjX-000AEm-Mo for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Apr 2022 18:39:15 +0200 Original-Received: from localhost ([::1]:45130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbPjW-0001ag-NZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Apr 2022 12:39:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbPjK-0001Y8-BE for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 12:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbPjK-0000NN-1l for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 12:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbPjJ-00050f-Tr for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2022 12:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Apr 2022 16:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53126-submit@debbugs.gnu.org id=B53126.164909033319236 (code B ref 53126); Mon, 04 Apr 2022 16:39:01 +0000 Original-Received: (at 53126) by debbugs.gnu.org; 4 Apr 2022 16:38:53 +0000 Original-Received: from localhost ([127.0.0.1]:52820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbPjB-00050C-J3 for submit@debbugs.gnu.org; Mon, 04 Apr 2022 12:38:53 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:55893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbPj9-0004zt-MQ for 53126@debbugs.gnu.org; Mon, 04 Apr 2022 12:38:52 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6ABDF60009; Mon, 4 Apr 2022 16:38:43 +0000 (UTC) In-Reply-To: <87o81i5zzn.fsf@gmail.com> (Augusto Stoffel's message of "Sun, 03 Apr 2022 10:32:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229416 Archived-At: > I've attached a sketch of a macro to help activating the minibuffer lazy > highlight. It doesn't make query-replace-read-args exactly short, but > if you like this, I can prepare the patch. I realized we already have the macro minibuffer-with-setup-hook, so we don't need more macros. The purpose of minibuffer-with-setup-hook is to set up the minibuffer to the initial state with buffer-local variables. In case of lazy-highlighting, we can't set isearch variables directly, but all isearch variables can be replaced by one variable that contains a set of lazy-highlight parameters. For example: (minibuffer-with-setup-hook (lambda () (setq-local lazy-highlight-params `((case-fold ,case-fold-search) (regexp ,regexp-flag) (regexp-function ,(or replace-regexp-function (and current-prefix-arg (not (eq current-prefix-arg '-))) (and replace-char-fold (not regexp-flag) #'char-fold-to-regexp))))) (minibuffer-lazy-highlight-init)) (query-replace-read-from prompt regexp-flag)) where minibuffer-lazy-highlight-init does a little more than minibuffer-lazy-highlight-setup. Or maybe it's not needed, and minibuffer-lazy-highlight-setup should be enough. Or maybe instead of setq-local is can let-bind variables. Please also note that condition-case can be replaced by a hook in minibuffer-exit-hook that can remove highlighting after exiting the minibuffer. Alternatively, the same lambda above could be added to (add-hook 'minibuffer-setup-hook (lambda () ...))