From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#64373: 29.0.90; C-x t o while in minibuffer copies the current tab to the next tab Date: Mon, 03 Jul 2023 21:58:03 +0300 Organization: LINKOV.NET Message-ID: <86v8f03jir.fsf@mail.linkov.net> References: <86mt0gdcb4.fsf@mail.linkov.net> <87a5wgokn4.fsf@catern.com> <86v8f4bx4n.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8986"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 64373@debbugs.gnu.org, sbaugh@catern.com To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 03 21:06:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGOsO-0002EZ-VL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Jul 2023 21:06:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGOsA-0003sX-OG; Mon, 03 Jul 2023 15:06:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGOs6-0003s4-MO for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 15:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGOs6-00087D-DU for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 15:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGOs5-0002OD-TP for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 15:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2023 19:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64373 X-GNU-PR-Package: emacs Original-Received: via spool by 64373-submit@debbugs.gnu.org id=B64373.16884111319145 (code B ref 64373); Mon, 03 Jul 2023 19:06:01 +0000 Original-Received: (at 64373) by debbugs.gnu.org; 3 Jul 2023 19:05:31 +0000 Original-Received: from localhost ([127.0.0.1]:34507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGOrY-0002NO-0V for submit@debbugs.gnu.org; Mon, 03 Jul 2023 15:05:31 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:49491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGOrS-0002N3-Si for 64373@debbugs.gnu.org; Mon, 03 Jul 2023 15:05:27 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 8304320004; Mon, 3 Jul 2023 19:05:14 +0000 (UTC) In-Reply-To: (Spencer Baugh's message of "Mon, 03 Jul 2023 13:18:19 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264547 Archived-At: > I agree we should not switch tabs without user's consent. However I > would argue that tabs are basically part of window configuration, since > they're a way of managing named window configurations, and if the user > has set read-minibuffer-restore-windows to t then we should should > restore the current tab as part of window configuration. > > I also agree that read-minibuffer-restore-windows should probably > default to nil. But that's a separate discussion, changing a more > significant default. > > Again: The current behavior of read-minibuffer-restore-windows is to > restore window configurations, but not restore the tab. I say this is a > bug, even if it's documented as doing that, which it is not. It clearly > behaves badly, wiping out user data without user action: It wipes out > the window configuration in the tab that the user switched to. That's > definitely bad. And I agree that we should do something to fix this behavior. But what to do exactly is not yet clear. While looking at the tabs as frames grouped inside one frame, then by analogy we could do the same how read-minibuffer-restore-windows behaves in regard to frames. After replacing 'C-x t' with 'C-x 5' in your test case, I see that read-minibuffer-restore-windows=t works inconsistently. You can also try to change buffers in both frames while the minibuffer is active. Then exiting the minibuffer does unexpected things. So maybe tabs would need own solution, e.g. with a new variable read-minibuffer-restore-tabs based on read-minibuffer-restore-windows, or a new variable minibuffer-follows-selected-tab based on minibuffer-follows-selected-frame.