unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Elijah G." <eg642616@gmail.com>
To: 71313@debbugs.gnu.org
Subject: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert
Date: Sat, 01 Jun 2024 18:17:42 -0600	[thread overview]
Message-ID: <86v82smc49.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

Tags: patch

Hello,

this little patch allow insert any package keywords when using
auto-insert for insert elisp header lines.

This is more a bugfix, since there is a bug when using Vertico that get
stuck in the keywords part, that bug can also apply to other completion
UIs or frameworks.

Also there are some packages that uses non-standard keywords, i think it
would be better allowing insert other keywords.



In GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32) of 2024-05-23 built
 on AVALON
Repository revision: 64cced2c37a9926fe6ff1c6ad9b9540abd47e21c
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 10.0.19045
System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.4046)

Configured using:
 'configure --with-modules --without-dbus --with-native-compilation --without-compress-install --with-tree-sitter CFLAGS=-O2'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Allow-insert-other-elisp-keywords-in-auto-insert.patch --]
[-- Type: text/patch, Size: 949 bytes --]

From 89f990c6393d90fd76efb4e3665f431d7c0300b3 Mon Sep 17 00:00:00 2001
From: "Elias G. Perez" <eg642616@gmail.com>
Date: Sat, 1 Jun 2024 16:51:54 -0600
Subject: [PATCH] Allow insert other elisp keywords in auto-insert

Allow to user confirm for insert other keywords than
default ones when using auto-insert in an elisp file.

* lisp/autoinsert.el (auto-insert-alist): Use 'confirm' instead
't' in completing-read REQUIRE-MATCH from Emacs Lisp header
template.
---
 lisp/autoinsert.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/autoinsert.el b/lisp/autoinsert.el
index f2631422c62..561626e474b 100644
--- a/lisp/autoinsert.el
+++ b/lisp/autoinsert.el
@@ -212,7 +212,7 @@ auto-insert-alist
 	   finder-known-keywords
 	   "\n"))
  ((let ((minibuffer-help-form v2))
-    (completing-read "Keyword, C-h: " v1 nil t))
+    (completing-read "Keyword, C-h: " v1 nil 'confirm))
     str ", ")
  & -2 "
 
-- 
2.44.0.windows.1


             reply	other threads:[~2024-06-02  0:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02  0:17 Elijah G. [this message]
2024-06-02  5:44 ` bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert Eli Zaretskii
2024-06-03  3:14   ` Elijah G.
2024-06-03 11:40     ` Eli Zaretskii
2024-06-05  0:54       ` Elijah G.
2024-06-05  5:24         ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-05 11:32         ` Eli Zaretskii
2024-06-07  5:10           ` Elijah G
2024-06-07  5:48             ` Thierry Volpiatto
2024-06-08  4:32             ` Elijah G
2024-06-08 13:26               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86v82smc49.fsf@gmail.com \
    --to=eg642616@gmail.com \
    --cc=71313@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).