From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71525: 30.0.50; Spin in delete-region/interval_deletion_adjustment Spin in delete-region/interval_deletion_adjustment) Date: Fri, 14 Jun 2024 21:46:23 +0300 Message-ID: <86v82bwef4.fsf@gnu.org> References: <87y17a55ny.fsf@stebalien.com> <87ikydo246.fsf@stebalien.com> <86o785z8wl.fsf@gnu.org> <87tthwrh8h.fsf@stebalien.com> <867ceszvp1.fsf@gnu.org> <87r0d0rfxa.fsf@stebalien.com> <87bk44bzf4.fsf@stebalien.com> <8634pgztx0.fsf@gnu.org> <86v82cxahx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6468"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 71525-done@debbugs.gnu.org, steven@stebalien.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 14 20:47:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIBxU-0001Rh-B0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jun 2024 20:47:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIBx1-00008h-55; Fri, 14 Jun 2024 14:47:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIBx0-00008V-CE for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 14:47:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIBx0-0002eH-4T for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 14:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sIBx0-0005rm-68 for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 14:47:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jun 2024 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71525 X-GNU-PR-Package: emacs Mail-Followup-To: 71525@debbugs.gnu.org, eliz@gnu.org, steven@stebalien.com Original-Received: via spool by 71525-done@debbugs.gnu.org id=D71525.171839079722511 (code D ref 71525); Fri, 14 Jun 2024 18:47:01 +0000 Original-Received: (at 71525-done) by debbugs.gnu.org; 14 Jun 2024 18:46:37 +0000 Original-Received: from localhost ([127.0.0.1]:40930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIBwa-0005qy-S4 for submit@debbugs.gnu.org; Fri, 14 Jun 2024 14:46:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIBwX-0005qk-9r for 71525-done@debbugs.gnu.org; Fri, 14 Jun 2024 14:46:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIBwR-0002bb-8N; Fri, 14 Jun 2024 14:46:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ny/EH2tMH0FTjmBJ1//cp4Gh3NvrmR10LFXsXYeC1+4=; b=iDGX4tdY116H xtVRXSW2MzLlq1qNJYbCw6RN/f65UxQXcs+FqzSmAcjienJpQrnMR2WPODhBKGOzwcxiPHrWLe4Zs dMKeG51rdp/tcjwEeDaOyhwt+CY4RFZikl3xxcyaxTFqPjvWTdl2Bdw84cyh1gsC3G5lZ0tGscrT5 w9/C1Ssjv7M80zJSRgkCxJl/TJacBok9Ux4qz5NwK1Yjogi7/1IQF+uHQkOXJNOgwYHA6pn+HHuOV FurxW5NqBqqZ84uCznCfObFbDtnTPhOIJk8N5jimZl/kQa7dcoig9V19BU+bXjMaYxhXP/EYSQhlB GdRguSFfb2A3P7jHoP0FPw==; In-Reply-To: (message from Dmitry Gutov on Fri, 14 Jun 2024 21:17:22 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287241 Archived-At: > Date: Fri, 14 Jun 2024 21:17:22 +0300 > Cc: steven@stebalien.com, jporterbugs@gmail.com, 71525@debbugs.gnu.org > From: Dmitry Gutov > > On 14/06/2024 10:13, Eli Zaretskii wrote: > >> /* Insert a sequence of NCHARS chars which occupy NBYTES bytes > >> starting at GAP_END_ADDR - NBYTES (if text_at_gap_tail) and at > >> - GPT_ADDR (if not text_at_gap_tail). */ > >> + GPT_ADDR (if not text_at_gap_tail). > >> + > >> + If BEFORE_MARKERS is true, insert before markers. */ > > This commentary should also mention process.c as the single caller > > using this facility in unconventional ways. > > Also note that I did make some effort to make the field > coding->insert_before_markers used consistently: in the changeset, it's > not just obeyed on the code path that decode_coding_c_string goes > through - it's used anywhere where insert_from_gap is called and a > coding_system structure is available - e.g. in encode_coding. > > Also in decode_coding_gap, but that one seems to only have one caller > (insert-file-contents), so that choice is moot. > > Something else I've noticed (a bit off topic): insert_from_gap_1's > comments says that it "does not invalidate any cache, nor update any > markers, nor record any buffer modification information of any sort", > but then it calls treesit_record_change when available. Not sure we need > to change that, but maybe we should update the comment, at least. Thanks, done. I think we can now close this bug.