From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71562: treesit-install-language-grammar fails to install typescript Date: Sun, 16 Jun 2024 08:16:03 +0300 Message-ID: <86v829sc18.fsf@gnu.org> References: <87v82bcrrm.fsf@dod.no> <47399af2-6982-4ce1-ad50-db426624edae@gutov.dev> <86msnmwwbk.fsf@gnu.org> <93d76485-2563-45e3-890d-d5bfc56ff4b7@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24310"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, sb@dod.no, 71562@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 16 07:19:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIiIU-00067H-EE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jun 2024 07:19:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIiIC-0001KS-FH; Sun, 16 Jun 2024 01:19:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIiIA-0001Jf-6z for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 01:19:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIiI9-0000r6-Pm for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 01:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sIiIA-0007HD-Dg for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 01:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2024 05:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71562 X-GNU-PR-Package: emacs Original-Received: via spool by 71562-submit@debbugs.gnu.org id=B71562.171851510827886 (code B ref 71562); Sun, 16 Jun 2024 05:19:02 +0000 Original-Received: (at 71562) by debbugs.gnu.org; 16 Jun 2024 05:18:28 +0000 Original-Received: from localhost ([127.0.0.1]:52462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIiHb-0007Fi-Iv for submit@debbugs.gnu.org; Sun, 16 Jun 2024 01:18:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIiHZ-0007FI-NJ for 71562@debbugs.gnu.org; Sun, 16 Jun 2024 01:18:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIiFL-0000PQ-1i; Sun, 16 Jun 2024 01:16:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=A9gDl7vtWpk7X7iE++NUb4LPLJFi2lBOA4kEbiNyeT8=; b=TF6PZD9CUMdT VkWpfQNL4+Bo8rFSfFtJKcE4yeZUupfmsC/Mo+nmb3ObBy1eh1o64V7jw6Ah7A/QzzBUdu5JbCOFl sqSI37bk6RCu328lUCSzxpZOMHbPn/PIOvZxn5bNw2NRtD4keJM8yQWBYBabmSNvNBTCB01KzWMdZ eaI9WvPRVFBDH+tW1g9kEFbk3OrSRWXgZ3c8G8opWFT6ygIw2w9EZ4pKxsvYVBuieeDn8CpEjs8Q/ xgPFuxFKLnm6RBxjh6A5APTvnKA42tQ9M2PvZxWcck9eOfOLu6tYc7csZlY6yuuQ0tFQf7kP9CvJ+ xN43RDQzW2Q9KpM66YmxMw==; In-Reply-To: <93d76485-2563-45e3-890d-d5bfc56ff4b7@gutov.dev> (message from Dmitry Gutov on Sat, 15 Jun 2024 22:30:25 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287320 Archived-At: > Date: Sat, 15 Jun 2024 22:30:25 +0300 > Cc: sb@dod.no, 71562@debbugs.gnu.org > From: Dmitry Gutov > > On 15/06/2024 09:31, Eli Zaretskii wrote: > > We could look for directories names 'src' which have either parser.c > > or parser.cc, and take it from there, instead of hard-coding the place > > of the 'src' directory in the hierarchy. > > In the present case we have two problems: > > * https://github.com/tree-sitter/tree-sitter-typescript/ contains two > different files called parser.c in two different subdirectories (in > typescript/src and tsx/src). > > * The repository for the 'tsx' grammar does not match the common scheme > - instead it's the same repository as for 'typescript'. I'm saying that we should run the build commands in every subdirectory called 'src' that has parser.c or parser.cc in it. Each shared library thus created should be installed. The name of the library is derived from the parent of the 'src' subdirectory.