From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors Date: Sat, 22 Jun 2024 11:34:02 +0300 Message-ID: <86v821idfp.fsf@gnu.org> References: <86jzk03exp.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35373"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70797-done@debbugs.gnu.org To: Rudolf (Rudy) Adamkovic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 10:35:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKwDZ-00090m-F8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 10:35:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKwDH-0007RH-1O; Sat, 22 Jun 2024 04:35:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKwD9-0007OZ-81 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 04:35:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKwD9-0005Ly-0N for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 04:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKwD8-0008LH-KS for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 04:35:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 08:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 70797@debbugs.gnu.org, eliz@gnu.org, rudolf@adamkovic.org Original-Received: via spool by 70797-done@debbugs.gnu.org id=D70797.171904525331988 (code D ref 70797); Sat, 22 Jun 2024 08:35:02 +0000 Original-Received: (at 70797-done) by debbugs.gnu.org; 22 Jun 2024 08:34:13 +0000 Original-Received: from localhost ([127.0.0.1]:44304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwCK-0008Jr-Sl for submit@debbugs.gnu.org; Sat, 22 Jun 2024 04:34:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKwCI-0008Jd-Jx for 70797-done@debbugs.gnu.org; Sat, 22 Jun 2024 04:34:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKwCD-00053k-KN; Sat, 22 Jun 2024 04:34:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yzS2YskFWXx0FsRnj6e4wxqippPB6eqS8klSXkY+XFQ=; b=rKHWWJ+1hVtb SI7nPaBFPNbzgPTLfQLPkO4S0kVdEXqpT+39iHrh8V3nmQRjfjoVU9zI6tfzx4Xf4qFEheIWSDlSa 1cS/j0YuvFt/ipXFWnJMxmPvGYpB7H//10cgrbF8w5FYQrXl+qkYQMhIJsYov1shktitgYYLETlp5 6kMjogQN1NmQZfeQ207TY/kFHRqj7DhJMIX4UAYXo3rmvNY3rhpBxQy6AdUVFbO5jpySlPwyNEOXE 7tLEbPc3UuzPQpHF1qwetHokMkwY0/8IiEefFbFFowdEaw+Fnq+uI3p7qJ4gq24OjZM+ALahQfj59 3iPjjj7+7uHItglESjMS6g==; In-Reply-To: (rudolf@adamkovic.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287664 Archived-At: > From: Rudolf (Rudy) Adamkovic > Cc: 70797@debbugs.gnu.org > Date: Thu, 13 Jun 2024 16:44:04 +0200 > > Eli Zaretskii writes: > > > . applying this fails compile-tests in the test suite, so I guess > > some adjustment there is also needed; > > Oops! In the new patch, attached below, I > > - adjust the existing legacy Gradle/Kotlin tests and > - add new tests for the non-legacy Gradle/Kotlin warnings/errors. > > I also improved the commit message a bit. > > > . you removed the comment with the pointer to kotlin sources, which > > might be still useful for the legacy format (unless the URL is no > > longer valid), so please restore that if the pointer can still be > > useful > > Smart! All right, I did a bit of research, and documented > > - the first and last Kotlin version that emits the current format, > - the last Kotlin version that used the legacy format, > - the official Git commit that removed the legacy format, > - the public release date of the current format, and > - the Kotlin class where the current format is defined. > > All of it is packed into two short comments. Thanks, installed on the master branch, and closing the bug. P.S. Please in the future mention the bug number in the commit log messages, when you know the number. In the initial submission of a patch, the number is usually not known, but if you resubmit, it usually is known already. (I added the bug number when installing the changes.)