From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Thu, 04 Jul 2024 15:50:56 +0300 Message-ID: <86v81l8gnj.fsf@gnu.org> References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> <878qyh79ov.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28351"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jpw@gnu.org, juri@linkov.net, me@eshelyaron.com, basil@contovou.net, 71927@debbugs.gnu.org, kickingvegas@gmail.com To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 14:54:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPLyT-00078r-Ev for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 14:54:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPLyN-0004Iu-Tn; Thu, 04 Jul 2024 08:54:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPLyL-0004Bi-6N for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 08:54:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPLyK-0007sq-4N for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 08:54:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPLyM-00008v-G9 for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 08:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 12:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.1720097605501 (code B ref 71927); Thu, 04 Jul 2024 12:54:02 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 4 Jul 2024 12:53:25 +0000 Original-Received: from localhost ([127.0.0.1]:41754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPLxl-000080-CI for submit@debbugs.gnu.org; Thu, 04 Jul 2024 08:53:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPLxg-00007h-B6 for 71927@debbugs.gnu.org; Thu, 04 Jul 2024 08:53:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPLvQ-0007DZ-6e; Thu, 04 Jul 2024 08:51:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4e/QT22y63cbFgK/TpjoBZPOhIs7a27jZIO2yPvMOVQ=; b=GWhyY+4AEgez yRXW6yVIZqwgP9aFsomFw18OeV/hiqyUBxKqfZD162kFjvvu/0Gw0+8UpLXOETSnFgzJJgv92z34W FThq7E1JW4pu0kK+L/cokWNerL3csAiySirNvpYsbO9aiT1Ofh/4i5rKTLCjssTXoHs5nyH69jbtV JI4+3KQllBuK6iWZBP5T4de89Rl2sGQTzk7eLJyG2lcmAU0gDVbYKcbM5flBKxvxP1K6IwLG8FR+s bWAcsre9fuDgeZqBT3Q+f915OJHyfCdmeLgseFINl0OVVIThVIJeqkuNpf61BtVzOaC21+VKSNzyU 8JUR9WLOZ/LgAwnbbAXjcA==; In-Reply-To: <878qyh79ov.fsf@gmx.net> (message from Stephen Berman on Thu, 04 Jul 2024 12:06:40 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288368 Archived-At: > From: Stephen Berman > Cc: Eshel Yaron , kickingvegas@gmail.com, > 71927@debbugs.gnu.org, basil@contovou.net, jpw@gnu.org, > juri@linkov.net > Date: Thu, 04 Jul 2024 12:06:40 +0200 > > >> FWIW, AFAICT everything is working correctly, it's just that the > >> "Operation finished" message hides the prompt. ibuffer-do-isearch > >> should tell define-ibuffer-op not to display that message, somehow. > > > > I don't see how this could be considered "correct": the "Operation > > finished" message is supposed to be shown only after the Isearch is > > finished in all the marked buffer, not before. It looks like we need > > a function that will not return until all the buffers where searched, > > because that's what define-ibuffer-op expects. Don't you agree? > > The attached patch appears to DTRT, but I only tested it briefly. Thanks, but does it really make sense to change define-ibuffer-op to fix the functions which (evidently) use it incorrectly? I think the fix needs to be in the same place where the bug is.