From: Juri Linkov <juri@linkov.net>
To: Dan Jacobson <jidanni@jidanni.org>
Cc: 72282@debbugs.gnu.org
Subject: bug#72282: History entries shouldn't have the exact region hardwired in
Date: Thu, 25 Jul 2024 21:12:44 +0300 [thread overview]
Message-ID: <86v80tig7r.fsf@mail.linkov.net> (raw)
In-Reply-To: <87o76m1ilb.1.fsf@jidanni.org> (Dan Jacobson's message of "Thu, 25 Jul 2024 07:22:08 +0800")
> (repeat-complex-command)
> is great, except when used after
> (shell-command-on-region)
> in which case we will be repeating
> (shell-command-on-region 2234 2892 ...)
> instead of just
> (shell-command-on-region REGION-START REGION-END ...)
> in other words the previous exact region is hardwired into
> the history.
>
> Yes, you might say well then just do `M-| <up> RET`.
> Well that's harder to type than `<again>`, `<redo>`, `C-x M-:` or `C-x M-ESC`,
> which are the bindings of repeat-complex-command.
>
> So maybe for all history items, they shouldn't have the exact region hardwired in.
Currently this can be achieved with a 'declare' form,
but I don't know why this is not enabled consistently
for region arguments of more commands:
diff --git a/lisp/simple.el b/lisp/simple.el
index a9f8b5845d8..b3a72c2635a 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -4944,6 +4944,9 @@ shell-command-on-region
The differences are especially prominent when the region includes
more than one line, i.e. when piping to a shell commands with embedded
newlines."
+ (declare (interactive-args
+ (start (use-region-beginning))
+ (end (use-region-end))))
(interactive (let (string)
(unless (mark)
(user-error "The mark is not set now, so there is no region"))
next prev parent reply other threads:[~2024-07-25 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 23:22 bug#72282: History entries shouldn't have the exact region hardwired in Dan Jacobson
2024-07-25 2:06 ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25 18:12 ` Juri Linkov [this message]
2024-08-19 6:49 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v80tig7r.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=72282@debbugs.gnu.org \
--cc=jidanni@jidanni.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).