From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73440: 31.0.50; shr-test/zoom-condition test fails if built w/o libxml2 support Date: Mon, 23 Sep 2024 17:24:42 +0300 Message-ID: <86v7ymfnx1.fsf@gnu.org> References: <87tte6y0p3.fsf@gentoo.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7704"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 73440@debbugs.gnu.org To: Sam James Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 23 16:26:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssk0m-0001iQ-Jj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Sep 2024 16:26:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssk0V-0005nZ-3t; Mon, 23 Sep 2024 10:25:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssk0R-0005mz-Cs for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 10:25:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssk0Q-0003gK-UG for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 10:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=5SEvto+5XvEkLg524IAynT3WULLHRAXLNFIYD4TEvOc=; b=O59hPMYBwq9uPib6VZ6kbvBmCYr+iMq3bVUmKVlQzoQPnHPOjPV66lzKIq0LME+W0pg6QqKt16pPdtCMs8Mazo2aTYJsIq+rs2T7F7X64JKhsF9lq7Yw61oRLM+xIME/8kmjqhSo12xm7EGC7DhGnoUL0FMg2WmklXotloUEINGCaDm7lmQMSWPZhTOW6AJlrfmxj4FcgZob1M4ZGjVZ8LU7iZUM7GWDukwngvEedofS4n0SYrAb00tyBakKj/6TGRy8UIUA4J6VSjRCzT+su0ZfxcOWCiX5Q0e5ROBnnDzPQTsOBJYxWxO3lrqLf2pX55I5eVFcEAlg9yymrK4syg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ssk0n-0000xq-T3 for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 10:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Sep 2024 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73440 X-GNU-PR-Package: emacs Original-Received: via spool by 73440-submit@debbugs.gnu.org id=B73440.17271015163150 (code B ref 73440); Mon, 23 Sep 2024 14:26:01 +0000 Original-Received: (at 73440) by debbugs.gnu.org; 23 Sep 2024 14:25:16 +0000 Original-Received: from localhost ([127.0.0.1]:44534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssk04-0000oh-8X for submit@debbugs.gnu.org; Mon, 23 Sep 2024 10:25:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssk02-0000oN-I7 for 73440@debbugs.gnu.org; Mon, 23 Sep 2024 10:25:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssjzY-0003Ql-QE; Mon, 23 Sep 2024 10:24:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5SEvto+5XvEkLg524IAynT3WULLHRAXLNFIYD4TEvOc=; b=Kk9zvHPwivhR 1mc7+zHnvInlAtHDYYl01FM9/O0xhRN7zRwvZn+TWf/T9GsrTx2cSNYytLedtGD6WunamnGjo73hB geQg48skJIbiVt7O76l3r3tHn/ore8yI5yj8Q6rXRzYQK6y2uULWMfBFXgWyK7NysfJW2mgSUPLLZ GmdjMnrbNYExscBvUeuW8wGD1KdqsKPjSz+VeMJ+4Wn20UXk4Ko7KskYR4j+OPYHZchPoHv19V4j6 Wh5TiBHX1WzXPgbBqnjgRA9Dk3wugiYtSBloz68x8rbZ4a1beydwt6kWToZvUyNNpIiXrSHwxEMvd oxce9mZ2Z/MtsCYAIRG54Q==; In-Reply-To: <87tte6y0p3.fsf@gentoo.org> (message from Sam James on Mon, 23 Sep 2024 14:11:20 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292280 Archived-At: > Cc: , Jim Porter > From: Sam James > Date: Mon, 23 Sep 2024 14:11:20 +0100 > > When building Emacs 31 without libxml2 support, I get a test failure: > """ > Test shr-test/zoom-image condition: > Info: image with alt=nil > (void-function libxml-parse-html-region) > FAILED 3/4 shr-test/zoom-image (0.000144 sec) at lisp/net/shr-tests.el:136 > passed 4/4 use-cookies (0.010334 sec) > > Ran 4 tests, 2 results as expected, 1 unexpected, 1 skipped (2024-09-23 14:07:16+0100, 0.081556 sec) > > 1 unexpected results: > FAILED shr-test/zoom-image libxml-parse-html-region > > 1 skipped results: > SKIPPED rendering ((skip-unless (fboundp 'libxml-parse-html-region)) :form (fboundp libxml-parse-html-region) :value nil) > """ > > Building with libxml2 support enabled fixes the test. Thanks, does the patch below solve the problem in a build without libxml2? diff --git a/test/lisp/net/shr-tests.el b/test/lisp/net/shr-tests.el index f8559df..d0fe803 100644 --- a/test/lisp/net/shr-tests.el +++ b/test/lisp/net/shr-tests.el @@ -136,6 +136,7 @@ shr-srcset (ert-deftest shr-test/zoom-image () "Test that `shr-zoom-image' properly replaces the original image." (skip-unless (bound-and-true-p image-types)) + (skip-unless (libxml-available-p)) (let* ((image (expand-file-name "data/image/blank-100x200.png" (getenv "EMACS_TEST_DIRECTORY"))) (image-url (concat "file://" (if (string-prefix-p "/" image)