unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Sam James <sam@gentoo.org>
Cc: jporterbugs@gmail.com, 73440@debbugs.gnu.org
Subject: bug#73440: 31.0.50; shr-test/zoom-condition test fails if built w/o libxml2 support
Date: Mon, 23 Sep 2024 17:24:42 +0300	[thread overview]
Message-ID: <86v7ymfnx1.fsf@gnu.org> (raw)
In-Reply-To: <87tte6y0p3.fsf@gentoo.org> (message from Sam James on Mon, 23 Sep 2024 14:11:20 +0100)

> Cc: , Jim Porter <jporterbugs@gmail.com>
> From: Sam James <sam@gentoo.org>
> Date: Mon, 23 Sep 2024 14:11:20 +0100
> 
> When building Emacs 31 without libxml2 support, I get a test failure:
> """
> Test shr-test/zoom-image condition:
>     Info: image with alt=nil
>     (void-function libxml-parse-html-region)
>    FAILED  3/4  shr-test/zoom-image (0.000144 sec) at lisp/net/shr-tests.el:136
>    passed  4/4  use-cookies (0.010334 sec)
> 
> Ran 4 tests, 2 results as expected, 1 unexpected, 1 skipped (2024-09-23 14:07:16+0100, 0.081556 sec)
> 
> 1 unexpected results:
>    FAILED  shr-test/zoom-image  libxml-parse-html-region
> 
> 1 skipped results:
>   SKIPPED  rendering  ((skip-unless (fboundp 'libxml-parse-html-region)) :form (fboundp libxml-parse-html-region) :value nil)
> """
> 
> Building with libxml2 support enabled fixes the test.

Thanks, does the patch below solve the problem in a build without
libxml2?

diff --git a/test/lisp/net/shr-tests.el b/test/lisp/net/shr-tests.el
index f8559df..d0fe803 100644
--- a/test/lisp/net/shr-tests.el
+++ b/test/lisp/net/shr-tests.el
@@ -136,6 +136,7 @@ shr-srcset
 (ert-deftest shr-test/zoom-image ()
   "Test that `shr-zoom-image' properly replaces the original image."
   (skip-unless (bound-and-true-p image-types))
+  (skip-unless (libxml-available-p))
   (let* ((image (expand-file-name "data/image/blank-100x200.png"
                                   (getenv "EMACS_TEST_DIRECTORY")))
          (image-url (concat "file://" (if (string-prefix-p "/" image)





  reply	other threads:[~2024-09-23 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 13:11 bug#73440: 31.0.50; shr-test/zoom-condition test fails if built w/o libxml2 support Sam James
2024-09-23 14:24 ` Eli Zaretskii [this message]
2024-09-23 14:46   ` Sam James
2024-09-23 15:31     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86v7ymfnx1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=73440@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).