From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing changes Date: Fri, 11 Oct 2024 09:07:00 +0300 Message-ID: <86v7xzyxyz.fsf@gnu.org> References: <640746f7-fa1c-dfb9-aaab-f9d8effdf64f@gutov.dev> <02b37700-a48d-4a7c-8e61-b37dfbabc062@gutov.dev> <86r09miu90.fsf@gnu.org> <030ceec6-427a-49af-a42e-2ad11f9a591b@gutov.dev> <86msjc34u5.fsf@gnu.org> <30132e72-ad22-493a-b89e-cffcedeee705@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7745"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 62940@debbugs.gnu.org, fgunbin@fastmail.fm To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 11 08:07:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sz8of-0001q7-2N for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Oct 2024 08:07:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sz8oa-0007vO-0I; Fri, 11 Oct 2024 02:07:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sz8oY-0007tD-DY for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2024 02:07:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sz8oX-0005R2-S8 for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2024 02:07:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=ae50GFvsRNC0l7E34Lo6cc6PrZqdWxlyphpk5ElD1aA=; b=Y4Rjl2SQFeJEqcofQJRiPeMng1XiDyITlT8qFLc7/2HP6EtjrMnkodwwGFQrsSS9omETIpR75m+Gmbfxnh2SwpvXtBXFtEcLsSX9jpJDJ0V5XhD5tL8TAaQlxVXAxf2ucOjvods8ESHG2C78C5kaOZI1CowdJcTUS1gmE0ZMBynpUSmAHTfmlUNaLXxAffDJn8ehKjF8i4MY92UM7oLykSUWutbJ1j96FQTeBa4mgiLXw3Yud9Uz6NjuYDI8IF8OZrtnD0+FESyDnQ21E/tBIf8KcJ+bbxzxq93O4VRR9xHKCwpMBjfBE8x3OsjKTlGPqob/GxnocYwCqNNyXOIjYw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sz8ok-0004C8-4U for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2024 02:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Oct 2024 06:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62940 X-GNU-PR-Package: emacs Original-Received: via spool by 62940-submit@debbugs.gnu.org id=B62940.172862684516080 (code B ref 62940); Fri, 11 Oct 2024 06:08:02 +0000 Original-Received: (at 62940) by debbugs.gnu.org; 11 Oct 2024 06:07:25 +0000 Original-Received: from localhost ([127.0.0.1]:33168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz8o9-0004BI-Ab for submit@debbugs.gnu.org; Fri, 11 Oct 2024 02:07:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sz8o7-0004B5-Pm for 62940@debbugs.gnu.org; Fri, 11 Oct 2024 02:07:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sz8np-0005Ml-JA; Fri, 11 Oct 2024 02:07:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ae50GFvsRNC0l7E34Lo6cc6PrZqdWxlyphpk5ElD1aA=; b=MBzEv9wl0e5e 11sSGNMB2y/OydowwuSD4wBkpqBFgXtDvapZ65GAoE6phv/PQJ9SPHqAqs5PsE1xqjmM3C+NdCL9F uaCXZ32I0UuOJLgSzhftcz7FnuhdbjTkbpzYoqmth7joHw0KEB1cNyo5FQ/INgbWUPn+BAnOpPT5D ZluzfTO5W3vVV2c68UXd2GkLQajU7eCE5PMO/wGN1jcw26bbYMAveGX2MrOEev/V1c2r2hcTKZFPb /UVeYFes2UlkJolrIqlbdkbsbYI2QOL2Lpf0EKRK7V1+RgKnsPhEDdOK6F+hqLK/ULjCF/8Ia6syZ wFWOVRz7mB+MYVfqNCQ+uA==; In-Reply-To: <30132e72-ad22-493a-b89e-cffcedeee705@gutov.dev> (message from Dmitry Gutov on Fri, 11 Oct 2024 04:13:24 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293332 Archived-At: > Date: Fri, 11 Oct 2024 04:13:24 +0300 > Cc: sbaugh@janestreet.com, 62940@debbugs.gnu.org, fgunbin@fastmail.fm > From: Dmitry Gutov > > Okay, check out this attempt. It might be considered too cluttered. > Perhaps you will have suggestions for improvement. This LGTM, thanks. One minor nit: > +@code{vc-diff} with a prefix argument: @kbd{C-u C-x v =}. This prompts > +for two revision IDs (@pxref{VCS Concepts}), and displays a diff between > +those versions of the fileset. The first one has several default > +values: the revision before the last one when the fileset changed, and > +the last revision of the current branch's upstream. > +The second defaults to nil, which means the contents of ^^^^^^^^^^ "Second" is ambiguous here (because of how the previous sentence ends), so I suggest to say "The second revision ID" instead to disambiguate it.