From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74287: [PATCH] Rework history Isearch for Eshell Date: Tue, 26 Nov 2024 15:11:48 +0530 Message-ID: <86v7waz603.fsf@gmx.net> References: <871pzjkhmm.fsf@pengjiz.com> <8c80ae91-476e-e665-43be-86d72fb57ed1@gmail.com> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25355"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74287@debbugs.gnu.org, Juri Linkov , Pengji Zhang , Sean Whitton To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 26 10:43:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tFs6M-0006Rj-Jq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Nov 2024 10:43:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFs64-00046Q-RR; Tue, 26 Nov 2024 04:43:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFs63-00045t-Cj for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 04:43:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tFs62-00052R-T3 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 04:43:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Nswr/yN0CnfkNCqkS3pGCTB/l/Sc22SWzIFa2vJ1nvA=; b=R1DKjgEGUxpVNE/juRe9On5bpLI5JLkphVcABDpF2jprM5qQjgLQvim7Vsb8cUEPGCi33seKiadYoUvMnNc48gSbSZWmbLaqT69F1Gem5ZALqElQ1RE39gcDSOCmKVS35+jXB+Wi3ZHtdaEam1xNbvVpcM2ZG7IFy5oWmRyMGgxoeSHfsYrp4tcaAaAaqpN3RPDmBHVraxJ+ZF4gCkeAS+hMIXEfZVyJcGFpRbmJDFdKc/TWbtDwp/Nvk66rpjaNqgxG9/1glKktKUMU9spg9qNNvp6pUhvWWdCTab1gD5cz8UuBvYjad4izjF6SaD7pliqR3E9BcRVVBpNJHp6GXg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tFs62-0008Vs-H1 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2024 04:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2024 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74287 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74287-submit@debbugs.gnu.org id=B74287.173261413032653 (code B ref 74287); Tue, 26 Nov 2024 09:43:02 +0000 Original-Received: (at 74287) by debbugs.gnu.org; 26 Nov 2024 09:42:10 +0000 Original-Received: from localhost ([127.0.0.1]:45786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFs5C-0008Ub-Cj for submit@debbugs.gnu.org; Tue, 26 Nov 2024 04:42:10 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:53259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFs5A-0008UL-A4 for 74287@debbugs.gnu.org; Tue, 26 Nov 2024 04:42:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1732614117; x=1733218917; i=jimjoe@gmx.net; bh=Nswr/yN0CnfkNCqkS3pGCTB/l/Sc22SWzIFa2vJ1nvA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=NsJ0FawSGrRpIo32J3bqiWcgcvbNNKBxIlHXCnGr4gbvgI7nAxrw0G1EiL1qHipT 67M+dwmlEW8OXidH6KeULtMq+FgCygDP2t+Nqoi0eob2inNvufcp83w0Y3RWrC4go LxBH1UI/6+G3EUg6TCp+lxpN9Lg8gyP1z+jG1CXlz/lcTUPK6Vj0ZsUpxGuvdNIYD NuM/F2VSD2ZHkN2fbiVy4NfN7PCZ/L25IGg813FxqDk04x27mxk46Qjd5dWTVHRyE 9CX1GR0QwBFHgzpG9qONYd8pQXYBOhvPO6An1U+yk2DvQa9YGNOSEWBO3WSOqWhW6 LRt1/ga4qOfxXD4RSA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-3493 ([42.108.19.2]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MOREi-1t4NLO2L8g-00Tvwl; Tue, 26 Nov 2024 10:41:57 +0100 In-Reply-To: <8c80ae91-476e-e665-43be-86d72fb57ed1@gmail.com> (Jim Porter's message of "Mon, 25 Nov 2024 22:53:36 -0800") X-Provags-ID: V03:K1:amVqeLLT/rRQCLZIBQgemseEhdUJT6IkmF2nPaNEgKGuxSD6mSG lD4UEG8f6ZMz//e9yHqK2CVQThYK3RPEpRILWqVMuY7AOEX0AffoyyzGnDHaY7p5BRYJY0d +e2MT7qfZPhRf0o5yntAUsFGrO2C6kLYU8nENEl5QV1wiR3owhRR4OI2X/tIMKR1/Sr87IA tRDKfN2fQWF5rcBL+0MBg== UI-OutboundReport: notjunk:1;M01:P0:FLADxacvPD0=;hMw1BlWO4TPMI7+mSh3hqTFciKK sVWuP7KKsSsc7FIrIVKJE3m6ZmqqXbhI1HkVgvifEmdLZpU7rGMcXemNNgfxVMAdbHgcI2dYN uhqBQ6Ve3i2UnJMKalUlBAtDh2jT2fvFl/CSUpWv+XWBwJPVsWRhrh0dKAcc+i8jcPJsmt3CH 6L6EfQ5Fl1JTrtjaDzuQx7SUfCpBbgr2Yvs08nowsQcYxpzVgGoLv1XT4x6ofU09DeAH7tXdT pyoWkgzjiYajB/L+PzIXxJvOfTfTi7s0ijxqR6CTVKDFydqeZbHXVdWenGAPyJkQ1VtwvqRCD Cafi54gzLIPbtASk8MJbhrWw0RFW0TlF8qFDYflMk3UF0YIaNyuKhsG1sU7oBWy8HV7fIAmGU i5k0Qm1fg8/3SrTKNeNZAUhjDuuOXjDKcblAdLUg9rjm4baSbGbUrwyh/mFruq/oml3jRJwhI OvC60UhmSVUTpF0n04pUZWrwYodPaXw2bPNVvqrbNCb7QkIVhdFPKMpYxSFXkmBQz9Oxj6hhh 2oJRtVrsuzeyXL74uKO0SqLLzHRSa5tl1oiWBLKn5UoPD17W7dF6Wp3dExPDCo5FRkN7gcrwa d016xpSytDFs/Oz42Z+3XiAsUCTUUVqOzznQj/kLFNag3NYLxWCskUajCVfnNW2mfXMHdQA5V P2FkNrPjKsva/HNhFZDlE95HQI/2ijaBjUlPeZQi/sZAIpVG3B2dKBXazqjXYNmrqmExP9d8E 3nXpD0jGPUWbzdT+susH+SkucV5B8Wp7poRebJh1FtF0lSFh41v5q0pNkjm6eVeXX1Bwc2I1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295982 Archived-At: Jim Porter wrote: > On 11/9/2024 5:22 PM, Pengji Zhang wrote: >> Hello, >> This patch brings a comint-like interface for history Isearch to >> Eshell. >> To try it, type 'M-r' in Eshell, and search through the input history >> ring incrementally. > > From inspection, this code all looks good to me. At least, it matches > what Comint does; I don't know much about Isearch's implementation, so > I'm just trusting that Comint is right here. Since this is a > somewhat-large patch, I'm going to try and find some time this week to > test it out so that I understand how it all works, and assuming I > don't find any major problems, I'll merge it shortly after that. My 2c: I now think it's better to hold out for something with way less code, using capf. --