From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 74287@debbugs.gnu.org, Juri Linkov <juri@linkov.net>,
Pengji Zhang <me@pengjiz.com>,
Sean Whitton <spwhitton@spwhitton.name>
Subject: bug#74287: [PATCH] Rework history Isearch for Eshell
Date: Tue, 26 Nov 2024 15:11:48 +0530 [thread overview]
Message-ID: <86v7waz603.fsf@gmx.net> (raw)
In-Reply-To: <8c80ae91-476e-e665-43be-86d72fb57ed1@gmail.com> (Jim Porter's message of "Mon, 25 Nov 2024 22:53:36 -0800")
Jim Porter wrote:
> On 11/9/2024 5:22 PM, Pengji Zhang wrote:
>> Hello,
>> This patch brings a comint-like interface for history Isearch to
>> Eshell.
>> To try it, type 'M-r' in Eshell, and search through the input history
>> ring incrementally.
>
> From inspection, this code all looks good to me. At least, it matches
> what Comint does; I don't know much about Isearch's implementation, so
> I'm just trusting that Comint is right here. Since this is a
> somewhat-large patch, I'm going to try and find some time this week to
> test it out so that I understand how it all works, and assuming I
> don't find any major problems, I'll merge it shortly after that.
My 2c: I now think it's better to hold out for something with way less
code, using capf.
--
prev parent reply other threads:[~2024-11-26 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-10 1:22 bug#74287: [PATCH] Rework history Isearch for Eshell Pengji Zhang
2024-11-10 23:40 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-12 8:54 ` Pengji Zhang
2024-11-26 6:53 ` Jim Porter
2024-11-26 9:41 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v7waz603.fsf@gmx.net \
--to=bug-gnu-emacs@gnu.org \
--cc=74287@debbugs.gnu.org \
--cc=jimjoe@gmx.net \
--cc=jporterbugs@gmail.com \
--cc=juri@linkov.net \
--cc=me@pengjiz.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).