From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juan Jose Garcia-Ripoll Newsgroups: gmane.emacs.bugs Subject: bug#37638: Patches Date: Sun, 06 Oct 2019 18:42:38 +0200 Message-ID: <86tv8lu8ox.wl-juanjose.garcia.ripoll@csic.es> References: <86eezpdfuk.fsf@csic.es> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149619"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) To: 37638@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 06 20:13:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHB1s-000cpc-Ss for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Oct 2019 20:13:13 +0200 Original-Received: from localhost ([::1]:36214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHB1r-0001TG-Pm for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Oct 2019 14:13:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43900) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHB1i-0001T2-Ss for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2019 14:13:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHB1h-0004FP-TI for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2019 14:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHB1h-0004FL-Qg for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2019 14:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHB1h-0000m2-Kf for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2019 14:13:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <86eezpdfuk.fsf@csic.es> Resent-From: Juan Jose Garcia-Ripoll Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Oct 2019 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37638 X-GNU-PR-Package: emacs Original-Received: via spool by 37638-submit@debbugs.gnu.org id=B37638.15703855622943 (code B ref 37638); Sun, 06 Oct 2019 18:13:01 +0000 Original-Received: (at 37638) by debbugs.gnu.org; 6 Oct 2019 18:12:42 +0000 Original-Received: from localhost ([127.0.0.1]:46836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHB1N-0000lP-KG for submit@debbugs.gnu.org; Sun, 06 Oct 2019 14:12:42 -0400 Original-Received: from cel1.sgai.csic.es ([161.111.10.57]:42653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iH9cF-0006gj-5Y for 37638@debbugs.gnu.org; Sun, 06 Oct 2019 12:42:39 -0400 IronPort-PHdr: 9a23:2oBqchYIEkqMkRzj2PzgXyj/LSx+4OfEezUN459isYplN5qZr824bnLW6fgltlLVR4KTs6sC17ON9f29EjVYv96oizMrSNR0TRgLiMEbzUQLIfWuLgnFFsPsdDEwB89YVVVorDmROElRH9viNRWJ+iXhpTEdFQ/iOgVrO+/7BpDdj9it1+C15pbffxhEiCCybL9vIhi6twXcu8kZjYd/Nqo8ywbCr2dVdehR2W5mP0+YkQzm5se38p5j8iBQtOwk+sVdT6j0fLk2QKJBAjg+PG87+MPktR/YTQuS/XQcSXkZkgBJAwfe8h73WIr6vzbguep83CmaOtD2TawxVD+/4apnVAPkhSEaPDM/7WrZiNF/jLhDrRyvpBJxw5DabpybO/VxYqzQZs8aSXZbU8pNSyBMGJ2wYo0SBOQBJ+ZYqIz9qkMKoxujHwasAv7kxDtPhn/tw6IxzuUvHhvc3AM8HtIBqm3Yosn0NKcKVuC1yK3IxijEYvNUxDfy8o7IchImofGXQ718a8XRxlM1FwzZj1Wfs5bpPymU1uQVtGib6+5gWPmzhG48qgF+viKjydk3ioTQgI8e11PK9T1hzYooOdG0UlN3bcK4HJdKtCyWKZF6T8wmTm1wuys216cKtYKhcCUE1Jgr3R/SZ+KBfoOV+BzsTvyRLi19hH99fbK/gAu9/la4x+3nU8m0zE5Kri1YktnQrnwN1wLc6syASvZl5Ueh3CqP1xjS6uFCO0w7ibHbK589zbIqiJUTqlzPHi7wmErokK+bblgo 9vSy5+j6frnquoWQOoxqhg3kPakjntSzAeEiPQgPW2ib9/681Lrm/UDhQrVKk+c5kq/bsJDdPsQUuLS1AwBP3YY59xm/Di2p3M X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2FXCQAPGZpd/zFSZApmHQEBBQEMBQGBZ4MLlFuNNIMlhGGFAIJQCQEBAQ4THAEBhy04EwIMAQEBBAEBAQEBBQMBAQEChVROgjoihAVnIwyEHa8PGgKDLYIFhHaBNIFliySBHINuhSECYQKFFgStPAeCJYIHkxEbgjqLZwMQiwuHDaB5gWmBezMagxIBAUxPEIE3AQEBjnGQUSOCMAEB X-IPAS-Result: A2FXCQAPGZpd/zFSZApmHQEBBQEMBQGBZ4MLlFuNNIMlhGGFAIJQCQEBAQ4THAEBhy04EwIMAQEBBAEBAQEBBQMBAQEChVROgjoihAVnIwyEHa8PGgKDLYIFhHaBNIFliySBHINuhSECYQKFFgStPAeCJYIHkxEbgjqLZwMQiwuHDaB5gWmBezMagxIBAUxPEIE3AQEBjnGQUSOCMAEB X-IronPort-AV: E=Sophos;i="5.67,263,1566856800"; d="scan'208";a="29384610" Original-Received: from unknown (HELO smtpin.csic.es) ([10.100.82.49]) by cel1.sgai.csic.es with ESMTP; 06 Oct 2019 18:42:38 +0200 Original-Received: from deutsch.csic.es (unknown [81.0.30.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 08930807E) by smtpin.csic.es (Postfix) with ESMTPSA id 2BB9810A8EC1 for <37638@debbugs.gnu.org>; Sun, 6 Oct 2019 18:42:36 +0200 (CEST) X-Mailman-Approved-At: Sun, 06 Oct 2019 14:12:39 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168448 Archived-At: I modified by hand the sources of the 26.3 distribution and bytecompiled them. The following changes, indicating to base64-encode-string that it should not use newline characters, seem to fix the issue with this and other webs. diff -u "url-auth-old.el" "url-auth.el" --- url-auth-old.el Sun Oct 06 18:03:59 2019 +++ url-auth.el Sun Oct 06 18:10:38 2019 @@ -82,7 +82,7 @@ (cond ((and user pass) ;; Explicit http://user:pass@foo/ URL. Just return the credentials. - (setq retval (base64-encode-string (format "%s:%s" user pass)))) + (setq retval (base64-encode-string (format "%s:%s" user pass) t))) ((and prompt (not byserv)) (setq user (or (url-do-auth-source-search server type :user) @@ -97,7 +97,8 @@ (setq retval (base64-encode-string (format "%s:%s" user - (encode-coding-string pass 'utf-8)))))) + (encode-coding-string pass 'utf-8)) + t)))) (symbol-value url-basic-auth-storage)))) (byserv (setq retval (cdr-safe (assoc file byserv))) @@ -120,7 +121,7 @@ pass (or (url-do-auth-source-search server type :secret) (read-passwd "Password: ")) - retval (base64-encode-string (format "%s:%s" user pass)) + retval (base64-encode-string (format "%s:%s" user pass) t) byserv (assoc server (symbol-value url-basic-auth-storage))) (setcdr byserv (cons (cons file retval) (cdr byserv))))))