From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Date: Sun, 05 Dec 2021 19:59:22 +0200 Organization: LINKOV.NET Message-ID: <86tufn5jn9.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39714"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52293@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 05 19:11:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtvyt-000ADX-5B for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 19:11:23 +0100 Original-Received: from localhost ([::1]:42974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtvyr-0005Ve-Ad for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 13:11:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtvxa-0003oD-Tv for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 13:10:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtvxa-0006Kn-8T for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 13:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtvxa-0000eH-3i for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 13:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2021 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16387277552397 (code B ref 52293); Sun, 05 Dec 2021 18:10:02 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 5 Dec 2021 18:09:15 +0000 Original-Received: from localhost ([127.0.0.1]:59362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtvwp-0000cS-HF for submit@debbugs.gnu.org; Sun, 05 Dec 2021 13:09:15 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:33965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtvwo-0000Zq-CH for 52293@debbugs.gnu.org; Sun, 05 Dec 2021 13:09:14 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 533E060006; Sun, 5 Dec 2021 18:09:06 +0000 (UTC) In-Reply-To: (Jim Porter's message of "Sat, 4 Dec 2021 21:58:24 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221623 Archived-At: > (defun help-mode-context-menu (menu click) > "Populate MENU with Help mode commands at CLICK." > - (define-key menu [help-mode-separator] menu-bar-separator) > + (define-key-after menu [help-mode-separator] menu-bar-separator > + 'top-separator) Now I realized that it's possible to do the same without 'top-separator': (define-key-after menu [help-mode-separator] menu-bar-separator "Context Menu") Or when the title string is defined as a variable: (defvar context-menu-title "Context Menu") (define-key-after menu [help-mode-separator] menu-bar-separator context-menu-title) But maybe 'top-separator' still could be used for clarity? Or it increases complexity?