From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Mon, 27 Dec 2021 21:52:13 +0200 Organization: LINKOV.NET Message-ID: <86tuethlle.fsf@mail.linkov.net> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> <871r1zm7ji.fsf@gmail.com> <87wnjrkrwd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 51809@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 27 20:54:44 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1w4y-0008kY-3x for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Dec 2021 20:54:44 +0100 Original-Received: from localhost ([::1]:34196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1w4w-0002Vr-GS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Dec 2021 14:54:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1w4I-000294-IQ for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 14:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1w4I-0007yn-8n for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 14:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1w4I-0006xa-8g for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 14:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Dec 2021 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.164063482526702 (code B ref 51809); Mon, 27 Dec 2021 19:54:02 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 27 Dec 2021 19:53:45 +0000 Original-Received: from localhost ([127.0.0.1]:44333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1w41-0006wb-19 for submit@debbugs.gnu.org; Mon, 27 Dec 2021 14:53:45 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:34965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1w3y-0006wG-Nk for 51809@debbugs.gnu.org; Mon, 27 Dec 2021 14:53:43 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 6B891E0006; Mon, 27 Dec 2021 19:53:34 +0000 (UTC) In-Reply-To: <87wnjrkrwd.fsf@gmail.com> (Matthias Meulien's message of "Sun, 26 Dec 2021 21:55:30 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223216 Archived-At: >> I am now back to the origin of this bug report (toggling visibility of >> some diff hunks depending on long lines, chunks size, or file names) and >> I see there's a major drawback with the outline mode default visibility >> state approach: When outline minor mode is set through diff-mode-hook, >> the buffer is emtpy and applying the default state visibility is a >> no-op; It's a side-effect of the buffer content being generated >> asynchronously... > > I fixed it using an advice to `vc-diff-finish', This problem is not specific to diff-mode. Like I demonstrated earlier, xref requires using xref-after-update-hook, so now it could look like this: #+begin_src emacs-lisp (add-hook 'xref-after-update-hook (lambda () (setq-local outline-regexp (if (eq xref-file-name-display 'abs) "/" "[^ 0-9]") outline-default-state 1) (outline-minor-mode) (outline-apply-default-state))) #+end_src > but wondering whether there's a clean way to achieve the same... Some time ago in another bug report I proposed to add a hook at the end of 'vc-diff-finish', so it will solve this problem. PS: Please give me more time to test your patch thoroughly in various modes.