From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc. Date: Wed, 23 Mar 2022 22:43:46 +0200 Organization: LINKOV.NET Message-ID: <86tuboz9fh.fsf@mail.linkov.net> References: <87sftyweb2.fsf@gmail.com> <87tuedp6pl.fsf@gmail.com> <861r1g7n3b.fsf@mail.linkov.net> <87o84jcx5x.fsf@gmail.com> <8635lvif0r.fsf@mail.linkov.net> <87mtidip1w.fsf@gmail.com> <86sfrjia5u.fsf@mail.linkov.net> <87ilseyks7.fsf@gmail.com> <868rt9wwji.fsf@mail.linkov.net> <871qz11w82.fsf@gmail.com> <86ilsc7e31.fsf@mail.linkov.net> <87tubwz9dd.fsf@gmail.com> <86sfrc2zr8.fsf@mail.linkov.net> <87o820iedv.fsf@gmail.com> <86h77s2wqo.fsf@mail.linkov.net> <87k0coibrt.fsf@gmail.com> <864k3o3j1g.fsf@mail.linkov.net> <87k0ck7b55.fsf@gmail.com> <86lex01m4a.fsf@mail.linkov.net> <86ee2s1lip.fsf@mail.linkov.net> <87czic76ov.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37638"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 53126@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 23 21:46:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX7rv-0009co-FE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 21:46:11 +0100 Original-Received: from localhost ([::1]:52870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nX7rt-0008Ff-T7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 16:46:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nX7rm-0008FD-L9 for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 16:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nX7rm-0004Vd-CE for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 16:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nX7rm-0002Vi-6f for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 16:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2022 20:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53126-submit@debbugs.gnu.org id=B53126.16480683319605 (code B ref 53126); Wed, 23 Mar 2022 20:46:02 +0000 Original-Received: (at 53126) by debbugs.gnu.org; 23 Mar 2022 20:45:31 +0000 Original-Received: from localhost ([127.0.0.1]:46177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX7rH-0002Ur-Jw for submit@debbugs.gnu.org; Wed, 23 Mar 2022 16:45:31 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:38233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX7rF-0002Ua-6D for 53126@debbugs.gnu.org; Wed, 23 Mar 2022 16:45:30 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id E798320004; Wed, 23 Mar 2022 20:45:21 +0000 (UTC) In-Reply-To: <87czic76ov.fsf@gmail.com> (Augusto Stoffel's message of "Wed, 23 Mar 2022 21:30:24 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228838 Archived-At: >> Probably the buffer order is changed by >> with-minibuffer-selected-window in >> minibuffer-lazy-highlight--after-change. >> This is fine, so I pushed your patch. > > FTR, I just tested and the culprit is not the > with-minibuffer-selected-window from > minibuffer-lazy-highlight--after-change (which makes sense, since that > macro uses NORECORD internally), but rather the calls to `select-window' > without NORECORD argument in isearch.el. I see that you use with-minibuffer-selected-window to start a new loop isearch-lazy-highlight-new-loop, but later every iteration of isearch-lazy-highlight-update needs to select the window again. Then adding NORECORD argument to `select-window' in lazy-highlight functions makes sense indeed.