From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57813: Icon images are non-functional Date: Sun, 23 Oct 2022 19:55:52 +0300 Organization: LINKOV.NET Message-ID: <86tu3u7a3r.fsf@mail.linkov.net> References: <86pmfxlp7s.fsf@mail.linkov.net> <861qsca9cn.fsf@mail.linkov.net> <867d2476u4.fsf@mail.linkov.net> <86zgequm55.fsf@mail.linkov.net> <87a66q2h1e.fsf@gnus.org> <86wn9s8zek.fsf@mail.linkov.net> <875ygp5cit.fsf@gmail.com> <86wn94ooqs.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25239"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 57813@debbugs.gnu.org To: Max Brieiev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 24 06:14:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omoqp-0006Su-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Oct 2022 06:14:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omnEK-0002ql-LU; Sun, 23 Oct 2022 22:30:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omeIU-0004SU-Gc for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 12:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omeIU-0000qZ-98 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 12:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omeIU-0006qi-29 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 12:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2022 16:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57813 X-GNU-PR-Package: emacs Original-Received: via spool by 57813-submit@debbugs.gnu.org id=B57813.166654422826263 (code B ref 57813); Sun, 23 Oct 2022 16:58:01 +0000 Original-Received: (at 57813) by debbugs.gnu.org; 23 Oct 2022 16:57:08 +0000 Original-Received: from localhost ([127.0.0.1]:46430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omeHb-0006pX-Vi for submit@debbugs.gnu.org; Sun, 23 Oct 2022 12:57:08 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omeHZ-0006p1-Gr for 57813@debbugs.gnu.org; Sun, 23 Oct 2022 12:57:06 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id ADCC0FF804; Sun, 23 Oct 2022 16:56:55 +0000 (UTC) In-Reply-To: <86wn94ooqs.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 12 Oct 2022 21:55:55 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246073 Archived-At: >> It seems in some cases this can cause an overlap between the heading and >> the image, like on the screenshot: > > It's hard to guess whether the outlines are using buttons or margins. > Probably buttons, because margins are not displayed in *Completions*. > Actually the same problem exists for both of them. By default the > button/margin face is inherited, because in most modes inheriting > fontification from the outline heading lines provides a nicer look, > but your example demonstrates that in some cases that face needs to be > overridden. Then there are several variants what face to use instead: > 1. the default face; 2. the outline faces outline-1, outline-2, ... > corresponding to the outline level. So it's not clear what to prefer here. Now refactored the outline button icon functions to support the face attribute of the icon for margins and buttons. So if an icon definition is customized to contain e.g. ':face default': (define-icon outline-open nil '((image "outline-open.svg" "outline-open.pbm" :height (0.8 . em) :face default) (symbol " ▼ " :face default)) then it doesn't inherit the outline heading face. > But there is a simpler way to avoid such a problem: it's possible > to customize the face 'completions-group-separator' to remove > the face attribute 'strike-through'. Then you can also use: > (setq-local outline-minor-mode-highlight 'override) > that will use the outline faces on the group headings, > and the button/margin will inherit it. For better compatibility with different face combinations, I changed the 'completions-group-separator' face attribute 'strike-through' to 'underline'.